Bug 155265 - Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
Summary: Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
Keywords: InRadar
: 155441 (view as bug list)
Depends on: 155185
  Show dependency treegraph
Reported: 2016-03-09 14:59 PST by Brent Fulgham
Modified: 2016-03-14 12:18 PDT (History)
6 users (show)

See Also:

Patch (4.46 KB, patch)
2016-03-09 18:00 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff
Patch (4.46 KB, patch)
2016-03-09 20:03 PST, Brent Fulgham
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-03-09 14:59:01 PST
Several tests break with <http://trac.webkit.org/changeset/197870> because code that sets the "allowFileAccessFromFileURLs" are getting blocked due to a disconnect between two flags on two different preference/configuration objects.

Temporarily encode "YES" as the default state for "_allowUniversalAccessFromFileURLs" to work around this, since we can't cleanly roll the patch out.

These tests break with the default "NO" state:

Comment 1 Brent Fulgham 2016-03-09 17:55:03 PST
Temporary workaround landed in <http://trac.webkit.org/changeset/197889>.
Comment 2 Brent Fulgham 2016-03-09 18:00:01 PST
Created attachment 273524 [details]
Comment 3 Andy Estes 2016-03-09 19:06:52 PST
Comment on attachment 273524 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=273524&action=review

> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:375
> +    configuration.get()._allowUniversalAccessFromFileURLs = YES;

[configuration _setAllowUniversalAccessFromFileURLs:YES];
Comment 4 Brent Fulgham 2016-03-09 20:03:06 PST
Created attachment 273539 [details]
Comment 5 Brent Fulgham 2016-03-09 20:06:38 PST
Committed r197920: <http://trac.webkit.org/changeset/197920>
Comment 6 Brent Fulgham 2016-03-10 08:40:48 PST
Comment 7 Brent Fulgham 2016-03-14 12:18:58 PDT
*** Bug 155441 has been marked as a duplicate of this bug. ***