WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155265
Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes test breakage
https://bugs.webkit.org/show_bug.cgi?id=155265
Summary
Handling 'allowUniversalAccessFromFileURLs' on WKWebViewConfiguration causes ...
Brent Fulgham
Reported
2016-03-09 14:59:01 PST
Several tests break with <
http://trac.webkit.org/changeset/197870
> because code that sets the "allowFileAccessFromFileURLs" are getting blocked due to a disconnect between two flags on two different preference/configuration objects. Temporarily encode "YES" as the default state for "_allowUniversalAccessFromFileURLs" to work around this, since we can't cleanly roll the patch out. These tests break with the default "NO" state: +fast/loader/stateobjects/replacestate-in-iframe.html +storage/domstorage/localstorage/access-storage-after-window-close.html +storage/domstorage/localstorage/access-storage-then-set-value-in-storage-after-window-close.html +storage/domstorage/localstorage/set-value-in-storage-after-window-close.html +storage/domstorage/localstorage/window-open.html +storage/domstorage/sessionstorage/window-open.html
Attachments
Patch
(4.46 KB, patch)
2016-03-09 18:00 PST
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Patch
(4.46 KB, patch)
2016-03-09 20:03 PST
,
Brent Fulgham
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Brent Fulgham
Comment 1
2016-03-09 17:55:03 PST
Temporary workaround landed in <
http://trac.webkit.org/changeset/197889
>.
Brent Fulgham
Comment 2
2016-03-09 18:00:01 PST
Created
attachment 273524
[details]
Patch
Andy Estes
Comment 3
2016-03-09 19:06:52 PST
Comment on
attachment 273524
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=273524&action=review
> Source/WebKit2/UIProcess/mac/WebInspectorProxyMac.mm:375 > + configuration.get()._allowUniversalAccessFromFileURLs = YES;
[configuration _setAllowUniversalAccessFromFileURLs:YES];
Brent Fulgham
Comment 4
2016-03-09 20:03:06 PST
Created
attachment 273539
[details]
Patch
Brent Fulgham
Comment 5
2016-03-09 20:06:38 PST
Committed
r197920
: <
http://trac.webkit.org/changeset/197920
>
Brent Fulgham
Comment 6
2016-03-10 08:40:48 PST
<
rdar://problem/25071049
>
Brent Fulgham
Comment 7
2016-03-14 12:18:58 PDT
***
Bug 155441
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug