Bug 155264 - Web Inspector: Get a RemoteObject or ObjectPreview from HeapSnapshot Object Identifier
Summary: Web Inspector: Get a RemoteObject or ObjectPreview from HeapSnapshot Object I...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks: 155287
  Show dependency tree / graph
 
Reported: 2016-03-09 14:57 PST by Joseph Pecoraro
Modified: 2016-03-10 11:24 PST (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (40.51 KB, patch)
2016-03-09 15:01 PST, Joseph Pecoraro 		timothy: review+
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from ews115 for mac-yosemite (906.36 KB, application/zip)
2016-03-09 15:58 PST, Build Bot 		no flags Details
[PATCH] For Landing (41.56 KB, patch)
2016-03-09 21:25 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-09 14:57:04 PST 
* SUMMARY
Get a RemoteObject or ObjectPreview from HeapSnapshot Object Identifier.
Comment 1 Radar WebKit Bug Importer 2016-03-09 14:57:30 PST 
<rdar://problem/25070716>
Comment 2 Joseph Pecoraro 2016-03-09 15:01:55 PST 
Created attachment 273488 [details]
[PATCH] Proposed Fix
Comment 3 WebKit Commit Bot 2016-03-09 15:03:13 PST 
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment 4 WebKit Commit Bot 2016-03-09 15:03:21 PST 
Attachment 273488 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/agents/InspectorHeapAgent.h:58:  The parameter name "functionDetails" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/inspector/agents/InspectorHeapAgent.h:58:  The parameter name "objectPreview" adds no information, so it should be removed.  [readability/parameter_name] [5]
Total errors found: 2 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Build Bot 2016-03-09 15:58:32 PST 
Comment on attachment 273488 [details]
[PATCH] Proposed Fix

Attachment 273488 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/950573

New failing tests:
inspector/heap/getPreview.html
Comment 6 Build Bot 2016-03-09 15:58:35 PST 
Created attachment 273498 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 7 Joseph Pecoraro 2016-03-09 21:25:22 PST 
Created attachment 273544 [details]
[PATCH] For Landing

Can't run these on WK1, because the inspector and inspected page sharing a VM causes heap explosion and confusion. Skipped them on WK1.
Comment 8 WebKit Commit Bot 2016-03-09 21:26:20 PST 
Attachment 273544 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/agents/InspectorHeapAgent.h:58:  The parameter name "functionDetails" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/JavaScriptCore/inspector/agents/InspectorHeapAgent.h:58:  The parameter name "objectPreview" adds no information, so it should be removed.  [readability/parameter_name] [5]
WARNING: Not running on native Windows.
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 9 WebKit Commit Bot 2016-03-09 22:15:15 PST 
Comment on attachment 273544 [details]
[PATCH] For Landing

Clearing flags on attachment: 273544

Committed r197926: <http://trac.webkit.org/changeset/197926>