Bug 155250 - WebsiteDataStore::Configuration::legacyWebsiteDataStoreConfiguration() should respect the passed-in configuration
Summary: WebsiteDataStore::Configuration::legacyWebsiteDataStoreConfiguration() should...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Conrad Shultz
Keywords: InRadar
Depends on:
Reported: 2016-03-09 12:22 PST by Conrad Shultz
Modified: 2016-03-09 13:30 PST (History)
2 users (show)

See Also:

Patch (2.49 KB, patch)
2016-03-09 12:30 PST, Conrad Shultz
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Shultz 2016-03-09 12:22:27 PST
Currently, WebsiteDataStore::Configuration::legacyWebsiteDataStoreConfiguration() respects the passed-in configuration's localStorageDirectory and webSQLDatabaseDirectory, but not the others. This makes it impossible for clients to override these other directories.

legacyWebsiteDataStoreConfiguration() should use the passed-in configuration for all applicable directories.
Comment 1 Conrad Shultz 2016-03-09 12:23:03 PST
Comment 2 Conrad Shultz 2016-03-09 12:30:23 PST
Created attachment 273460 [details]
Comment 3 Conrad Shultz 2016-03-09 13:21:06 PST
The mac-wk2 EWS failures relating to localstorage occur prior to this patch.
Comment 4 Conrad Shultz 2016-03-09 13:30:35 PST
Committed r197881: <http://trac.webkit.org/changeset/197881>