Bug 155248 - Add dumping of function expression names in CodeBlock bytecode dump.
Summary: Add dumping of function expression names in CodeBlock bytecode dump.
Status: REOPENED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords:
Depends on: 155262
Blocks:
  Show dependency tree / graph
 
Reported: 2016-03-09 12:08 PST by Mark Lam
Modified: 2016-03-09 14:31 PST (History)
7 users (show)

See Also:

Attachments
proposed patch. (4.88 KB, patch)
2016-03-09 12:13 PST, Mark Lam 		fpizlo: review-
Details | Formatted Diff | Diff
proposed patch: only dump extra info if not in compiler thread. (4.95 KB, patch)
2016-03-09 12:32 PST, Mark Lam 		fpizlo: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2016-03-09 12:08:42 PST 
Because ...
[  19] new_func_exp      loc5, loc3, f0:foo

... is more informative than
[  19] new_func_exp      loc5, loc3, f0

Patch coming soon.
Comment 1 Mark Lam 2016-03-09 12:13:34 PST 
Created attachment 273455 [details]
proposed patch.
Comment 2 Filip Pizlo 2016-03-09 12:23:27 PST 
Comment on attachment 273455 [details]
proposed patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=273455&action=review

> Source/JavaScriptCore/bytecode/CodeBlock.cpp:772
> +    String name = executable->inferredName().string();

This will not work on the concurrent JIT thread.
Comment 3 Mark Lam 2016-03-09 12:32:21 PST 
Created attachment 273461 [details]
proposed patch: only dump extra info if not in compiler thread.
Comment 4 Mark Lam 2016-03-09 12:36:57 PST 
Thanks for the review.  Landed in r197873: <http://trac.webkit.org/r197873>.
Comment 5 WebKit Commit Bot 2016-03-09 14:31:32 PST 
Re-opened since this is blocked by bug 155262