We should rename WebCore/platform/crypto/mac/CryptoDigestMac.cpp to WebCore/platform/crypto/cocoa/CryptoDigestCocoa.cpp since this file can be used on both iOS and OS X.
Created attachment 273448 [details] Patch
Comment on attachment 273448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273448&action=review > Source/WebCore/ChangeLog:10 > + Reviewed by NOBODY (OOPS!). > + * PlatformMac.cmake: Will add an empty line between these two lines before landing.
Comment on attachment 273448 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273448&action=review > Source/WebCore/ChangeLog:7 > + The file WebCore/platform/crypto/mac/CryptoDigestMac.cpp is applicable to both iOS and OS X. > + We should move and rename this file to reflect that is applicable to both of these platforms. This is a slight improvement, although possibly not the best name. This file does not use Cocoa.
(In reply to comment #3) > Comment on attachment 273448 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=273448&action=review > > > Source/WebCore/ChangeLog:7 > > + The file WebCore/platform/crypto/mac/CryptoDigestMac.cpp is applicable to both iOS and OS X. > > + We should move and rename this file to reflect that is applicable to both of these platforms. > > This is a slight improvement, although possibly not the best name. This file > does not use Cocoa. As per our conversation on IRC today, will rename file WebCore/platform/crypto/mac/CryptoDigestMac.cpp to WebCore/platform/crypto/commoncrypto/CryptoDigestCommonCrypto.cpp before landing.
Committed r197871: <http://trac.webkit.org/changeset/197871>