Bug 155231 – Move attributes to the instance for most interfaces that have "Error" in their name

• Status: RESOLVED
• Resolution: FIXED
• Component: Bindings

[Chris Dumez]

Move attributes to the instance for most interfaces that have "Error" in their name.

[Chris Dumez]

Created attachment 273428 [details]
Patch

[Build Bot]

Comment on attachment 273428 [details]
Patch

Attachment 273428 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/948085

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html

[Build Bot]

Created attachment 273434 [details]
Archive of layout-test-results from ews124 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews124  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Darin Adler]

Comment on attachment 273428 [details]
Patch

Need to fix iOS expected results too?

[Darin Adler]

Comment on attachment 273428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273428&action=review

> Source/WebCore/bindings/scripts/CodeGeneratorJS.pm:676
>      # FIXME: These two should be fixed by removing the custom override of message, etc

This comment no longer makes sense. It says “these two” but there are not two any more. It’s also unnecessarily vague. Would be better if it said something brief but a bit more specific.

[Chris Dumez]

Created attachment 273449 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 273449 [details]
Patch

Clearing flags on attachment: 273449

Committed r197874: <http://trac.webkit.org/changeset/197874>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.