Bug 155226 - Rename Node.treeRoot to rootNode and turn it on by default
Summary: Rename Node.treeRoot to rootNode and turn it on by default
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks: 148695
  Show dependency treegraph
 
Reported: 2016-03-09 01:49 PST by Ryosuke Niwa
Modified: 2016-03-09 19:10 PST (History)
5 users (show)

See Also:


Attachments
Renamed the function (70.32 KB, patch)
2016-03-09 01:58 PST, Ryosuke Niwa
tonikitoo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-03-09 01:49:19 PST
Rename Node.treeRoot to rootNode and turn it on by default
Comment 1 Ryosuke Niwa 2016-03-09 01:58:22 PST
Created attachment 273415 [details]
Renamed the function
Comment 2 Radar WebKit Bug Importer 2016-03-09 01:59:02 PST
<rdar://problem/25056663>
Comment 3 Antonio Gomes 2016-03-09 06:07:19 PST
Comment on attachment 273415 [details]
Renamed the function

View in context: https://bugs.webkit.org/attachment.cgi?id=273415&action=review

r=me

> Source/WebCore/html/FormAssociatedElement.cpp:86
> +// since inDocument flag maybe inaccurate.

s/maybe/may be/ ?
Comment 4 Ryosuke Niwa 2016-03-09 14:10:34 PST
Thanks for the review!

(In reply to comment #3)
> Comment on attachment 273415 [details]
> Renamed the function
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273415&action=review
> 
> r=me
> 
> > Source/WebCore/html/FormAssociatedElement.cpp:86
> > +// since inDocument flag maybe inaccurate.
> 
> s/maybe/may be/ ?

Revised the whole comment as:

// Compute the highest ancestor instead of calling Node::rootNode in removedFrom / formRemovedFromTree
// since inDocument flag on some form associated elements may not have been updated yet.
Comment 5 Ryosuke Niwa 2016-03-09 14:29:20 PST
Committed r197887: <http://trac.webkit.org/changeset/197887>