Bug 155216 – focus() / blur() should be on HTMLElement / SVGElement, not Element

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

focus() / blur() should be on HTMLElement / SVGElement, not Element:
- https://html.spec.whatwg.org/multipage/dom.html#htmlelement
- https://www.w3.org/TR/SVG2/types.html#InterfaceSVGElement

Chrome and Firefox match the specification.

[Chris Dumez]

Created attachment 273389 [details]
Patch

[Ryosuke Niwa]

Comment on attachment 273389 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273389&action=review

> Source/WebCore/ChangeLog:8
> +        focus() / blur() should be on HTMLElement / SVGElement, not Element:

How about MathML elements?

[Build Bot]

Comment on attachment 273389 [details]
Patch

Attachment 273389 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/946025

New failing tests:
imported/w3c/web-platform-tests/html/dom/interfaces.html

[Build Bot]

Created attachment 273409 [details]
Archive of layout-test-results from ews121 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews121  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Darin Adler]

Comment on attachment 273389 [details]
Patch

I guess this is OK, but it seems kind of weak; sort of old fashioned. I suppose there are a lot of things on HTMLElement that are useful on MathML and SVG elements and it’s a little strange that we do this by putting the functions separately on each of those classes. I wonder what the concept is for the future about accommodating new types of elements in that won’t support these operations.

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 273389 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273389&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        focus() / blur() should be on HTMLElement / SVGElement, not Element:
> 
> How about MathML elements?

I cannot find any IDL files for MathMLElements.

[Chris Dumez]

(In reply to comment #2)
> Comment on attachment 273389 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273389&action=review
> 
> > Source/WebCore/ChangeLog:8
> > +        focus() / blur() should be on HTMLElement / SVGElement, not Element:
> 
> How about MathML elements?

So, the specification does not seem to indicate that MathMLElement has either focus() or blur():
https://www.w3.org/TR/MathML2/appendixd.html

I have checked that in Firefox and Chrome, MathMLElement does not have focus() / blur() either.

[Chris Dumez]

Created attachment 273451 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 273451 [details]
Patch

Clearing flags on attachment: 273451

Committed r197875: <http://trac.webkit.org/changeset/197875>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.