Bug 155215 - Element with maximum tabIndex cannot be returned by nextElementWithGreaterTabIndex()
Summary: Element with maximum tabIndex cannot be returned by nextElementWithGreaterTab...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-08 20:41 PST by Chris Dumez
Modified: 2016-03-09 09:57 PST (History)
5 users (show)

See Also:

Attachments
Patch (4.66 KB, patch)
2016-03-08 20:49 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-03-08 20:41:38 PST 
Element with maximum tabIndex cannot be returned by nextElementWithGreaterTabIndex() due to a bug in <http://trac.webkit.org/changeset/197726>.
Comment 1 Chris Dumez 2016-03-08 20:49:47 PST 
Created attachment 273384 [details]
Patch
Comment 2 WebKit Commit Bot 2016-03-08 22:27:43 PST 
Comment on attachment 273384 [details]
Patch

Clearing flags on attachment: 273384

Committed r197835: <http://trac.webkit.org/changeset/197835>
Comment 3 WebKit Commit Bot 2016-03-08 22:27:47 PST 
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2016-03-08 23:09:22 PST 
The new test always times out on iOS. Can it be rewritten to work in a cross-platform way?
Comment 5 Chris Dumez 2016-03-09 09:17:09 PST 
(In reply to comment #4)
> The new test always times out on iOS. Can it be rewritten to work in a
> cross-platform way?

In EventSenderProxyIOS.mm:
void EventSenderProxy::keyDown(WKStringRef key, WKEventModifiers modifiers, unsigned keyLocation)
{
    // Write me.
}

iOS does not support EventSender.keydown() :/
Comment 6 Darin Adler 2016-03-09 09:57:35 PST 
But you don’t move focus to the next element by pressing a "tab key" on iOS either. I’m not sure that WebKit on iOS has code that understands the tab character. We might have to write something different to test tabIndex on that platform. Not sure there is a platform independent way of walking through the tab loop.