Bug 155214 – Align HTMLKeygenElement.keytype with the specification

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Chris Dumez]

Align HTMLKeygenElement.keytype with the specification:
- https://html.spec.whatwg.org/#dom-keygen-keytype
- https://html.spec.whatwg.org/#attr-keygen-keytype

In particular, the following changes need to be made:
1. It should return "rsa" by default (i.e. when the corresponding content attribute is missing)
2. It should only return known values

[Chris Dumez]

Created attachment 273380 [details]
Patch

[Build Bot]

Comment on attachment 273380 [details]
Patch

Attachment 273380 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: http://webkit-queues.webkit.org/results/946029

New failing tests:
imported/w3c/web-platform-tests/html/dom/reflection-forms.html

[Build Bot]

Created attachment 273408 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.10.5

[Darin Adler]

Comment on attachment 273380 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273380&action=review

Please don’t land until we figure out what to do for iOS.

> Source/WebCore/html/HTMLKeygenElement.cpp:117
> +    if (keytype() != "rsa")

I kind of wish that both the DOM keytype function and this function called a private function that returns a boolean, maybe call it hasValidKeyType or isKeyTypeRSA. Not as elegant to actually transform into a string just to do a string comparison.

[Chris Dumez]

Created attachment 273437 [details]
Patch

[Chris Dumez]

(In reply to comment #4)
> Comment on attachment 273380 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273380&action=review
> 
> Please don’t land until we figure out what to do for iOS.

Just need a rebaseline. Done before landing.

> 
> > Source/WebCore/html/HTMLKeygenElement.cpp:117
> > +    if (keytype() != "rsa")
> 
> I kind of wish that both the DOM keytype function and this function called a
> private function that returns a boolean, maybe call it hasValidKeyType or
> isKeyTypeRSA. Not as elegant to actually transform into a string just to do
> a string comparison.

Done before landing.

[WebKit Commit Bot]

Comment on attachment 273437 [details]
Patch

Clearing flags on attachment: 273437

Committed r197864: <http://trac.webkit.org/changeset/197864>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.