Bug 155213 - Add runtime flags for shadow DOM and custom elements
Summary: Add runtime flags for shadow DOM and custom elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-08 20:06 PST by Ryosuke Niwa
Modified: 2016-03-09 20:43 PST (History)
16 users (show)

See Also:


Attachments
Patch (23.37 KB, patch)
2016-03-08 20:50 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Patch (22.69 KB, patch)
2016-03-08 20:54 PST, Ryosuke Niwa
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from ews103 for mac-yosemite (1.06 MB, application/zip)
2016-03-08 22:01 PST, Build Bot
no flags Details
Archive of layout-test-results from ews112 for mac-yosemite (1009.61 KB, application/zip)
2016-03-08 22:25 PST, Build Bot
no flags Details
Fixed DRT (22.62 KB, patch)
2016-03-08 22:41 PST, Ryosuke Niwa
dino: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-03-08 20:06:47 PST
Add two runtime flags for shadow DOM and custom elements both behind compile time flags, and enable shadow DOM by default.
Comment 1 Ryosuke Niwa 2016-03-08 20:50:20 PST
Created attachment 273385 [details]
Patch
Comment 2 Ryosuke Niwa 2016-03-08 20:54:04 PST
Created attachment 273386 [details]
Patch
Comment 3 Radar WebKit Bug Importer 2016-03-08 21:11:42 PST
<rdar://problem/25053091>
Comment 4 Build Bot 2016-03-08 22:00:58 PST
Comment on attachment 273386 [details]
Patch

Attachment 273386 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/945311

New failing tests:
fast/custom-elements/Document-defineElement.html
fast/custom-elements/parser/parser-constructs-custom-element-synchronously.html
fast/custom-elements/parser/parser-uses-registry-of-owner-document.html
fast/custom-elements/upgrading/Node-cloneNode.html
fast/custom-elements/parser/parser-fallsback-to-unknown-element.html
fast/custom-elements/parser/parser-uses-constructed-element.html
fast/custom-elements/attribute-changed-callback.html
fast/custom-elements/parser/parser-constructs-custom-elements.html
fast/custom-elements/parser/parser-constructs-custom-element-in-document-write.html
fast/custom-elements/parser/parser-sets-attributes-and-children.html
fast/custom-elements/lifecycle-callback-timing.html
fast/custom-elements/HTMLElement-constructor.html
fast/custom-elements/Document-createElement.html
Comment 5 Build Bot 2016-03-08 22:01:03 PST
Created attachment 273391 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 6 Build Bot 2016-03-08 22:25:06 PST
Comment on attachment 273386 [details]
Patch

Attachment 273386 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/945318

New failing tests:
fast/custom-elements/parser/parser-uses-registry-of-owner-document.html
fast/custom-elements/parser/parser-constructs-custom-element-synchronously.html
fast/custom-elements/Document-defineElement.html
fast/custom-elements/upgrading/Node-cloneNode.html
fast/custom-elements/parser/parser-fallsback-to-unknown-element.html
fast/custom-elements/parser/parser-uses-constructed-element.html
fast/custom-elements/attribute-changed-callback.html
fast/custom-elements/parser/parser-constructs-custom-elements.html
fast/custom-elements/parser/parser-constructs-custom-element-in-document-write.html
fast/custom-elements/parser/parser-sets-attributes-and-children.html
fast/custom-elements/lifecycle-callback-timing.html
fast/custom-elements/HTMLElement-constructor.html
fast/custom-elements/Document-createElement.html
Comment 7 Build Bot 2016-03-08 22:25:11 PST
Created attachment 273393 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5
Comment 8 Ryosuke Niwa 2016-03-08 22:41:54 PST
Created attachment 273396 [details]
Fixed DRT
Comment 9 Ryosuke Niwa 2016-03-08 23:13:28 PST
Unfortunately, we can't quite test the runtime enabled-ness of these features correctly because attributes and functions on IDL objects are exposed as the global object is created.

We should able to add tests once that bug is fixed.
Comment 10 Csaba Osztrogonác 2016-03-08 23:31:37 PST
(In reply to comment #0)
> Add two runtime flags for shadow DOM and custom elements both behind compile
> time flags, and enable shadow DOM by default.

Do we want to enable these features on GTK, EFL and Windows ports too.
I checked their cmake build files and it seems they are still disabled.
If yes, please announce it on webkit-dev similar to the recent SVG->OTF thread.
Comment 11 Ryosuke Niwa 2016-03-08 23:49:00 PST
(In reply to comment #10)
> (In reply to comment #0)
> > Add two runtime flags for shadow DOM and custom elements both behind compile
> > time flags, and enable shadow DOM by default.
> 
> Do we want to enable these features on GTK, EFL and Windows ports too.
> I checked their cmake build files and it seems they are still disabled.
> If yes, please announce it on webkit-dev similar to the recent SVG->OTF
> thread.

Eventually but not now.
Comment 12 Ryosuke Niwa 2016-03-09 20:43:01 PST
Committed r197921: <http://trac.webkit.org/changeset/197921>