WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155211
Stop using the UserContentController for injecting the override style sheet from CaptionUserPreferences
https://bugs.webkit.org/show_bug.cgi?id=155211
Summary
Stop using the UserContentController for injecting the override style sheet f...
Sam Weinig
Reported
2016-03-08 18:57:05 PST
Stop using the UserContentController for injecting the override style sheet frrom CaptionUserPreferences
Attachments
Patch
(12.53 KB, patch)
2016-03-08 19:20 PST
,
Sam Weinig
no flags
Details
Formatted Diff
Diff
Patch
(10.68 KB, patch)
2016-03-08 20:06 PST
,
Sam Weinig
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Sam Weinig
Comment 1
2016-03-08 19:20:22 PST
Created
attachment 273372
[details]
Patch
Sam Weinig
Comment 2
2016-03-08 20:06:58 PST
Created
attachment 273376
[details]
Patch
mitz
Comment 3
2016-03-08 20:34:52 PST
Comment on
attachment 273376
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=273376&action=review
> Source/WebCore/dom/ExtensionStyleSheets.cpp:124 > + RefPtr<CSSStyleSheet> groupSheet = CSSStyleSheet::createInline(const_cast<Document&>(m_document), captionsStyleSheetURL.get());
Why is it called groupSheet?
Sam Weinig
Comment 4
2016-03-08 20:39:35 PST
Committed
r197831
: <
http://trac.webkit.org/changeset/197831
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug