Bug 155211 - Stop using the UserContentController for injecting the override style sheet from CaptionUserPreferences
Summary: Stop using the UserContentController for injecting the override style sheet f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Sam Weinig
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-08 18:57 PST by Sam Weinig
Modified: 2016-03-08 20:39 PST (History)
4 users (show)

See Also:

Attachments
Patch (12.53 KB, patch)
2016-03-08 19:20 PST, Sam Weinig 		no flags Details | Formatted Diff | Diff
Patch (10.68 KB, patch)
2016-03-08 20:06 PST, Sam Weinig 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2016-03-08 18:57:05 PST 
Stop using the UserContentController for injecting the override style sheet frrom CaptionUserPreferences
Comment 1 Sam Weinig 2016-03-08 19:20:22 PST 
Created attachment 273372 [details]
Patch
Comment 2 Sam Weinig 2016-03-08 20:06:58 PST 
Created attachment 273376 [details]
Patch
Comment 3 mitz 2016-03-08 20:34:52 PST 
Comment on attachment 273376 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273376&action=review

> Source/WebCore/dom/ExtensionStyleSheets.cpp:124
> +        RefPtr<CSSStyleSheet> groupSheet = CSSStyleSheet::createInline(const_cast<Document&>(m_document), captionsStyleSheetURL.get());

Why is it called groupSheet?
Comment 4 Sam Weinig 2016-03-08 20:39:35 PST 
Committed r197831: <http://trac.webkit.org/changeset/197831>