Bug 155210 - Delete dead scrolling code
Summary: Delete dead scrolling code
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on: 155222
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-08 17:28 PST by Myles C. Maxfield
Modified: 2016-03-09 15:35 PST (History)
12 users (show)

See Also:


Attachments
Patch (8.14 KB, patch)
2016-03-08 17:28 PST, Myles C. Maxfield
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-03-08 17:28:09 PST
Delete dead scrolling code
Comment 1 Myles C. Maxfield 2016-03-08 17:28:38 PST
Created attachment 273369 [details]
Patch
Comment 2 WebKit Commit Bot 2016-03-08 18:05:03 PST
Comment on attachment 273369 [details]
Patch

Clearing flags on attachment: 273369

Committed r197825: <http://trac.webkit.org/changeset/197825>
Comment 3 WebKit Commit Bot 2016-03-08 18:05:07 PST
All reviewed patches have been landed.  Closing bug.
Comment 4 Gyuyoung Kim 2016-03-08 23:05:27 PST
EFL port is still using scrollLayerForScrollableArea(). Why is this code dead ?
Comment 5 Csaba Osztrogonác 2016-03-08 23:12:02 PST
(In reply to comment #2)
> Comment on attachment 273369 [details]
> Patch
> 
> Clearing flags on attachment: 273369
> 
> Committed r197825: <http://trac.webkit.org/changeset/197825>

It broke the EFL build:

../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: In member function ‘virtual void WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange(WebCore::ScrollableArea&)’:
../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:99:109: error: ‘scrollLayerForScrollableArea’ was not declared in this scope
     CoordinatedGraphicsLayer* layer = toCoordinatedGraphicsLayer(scrollLayerForScrollableArea(scrollableArea));
                                                                                                             ^
../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: In member function ‘virtual void WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea(WebCore::ScrollableArea&)’:
../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:108:109: error: ‘scrollLayerForScrollableArea’ was not declared in this scope
     CoordinatedGraphicsLayer* layer = toCoordinatedGraphicsLayer(scrollLayerForScrollableArea(scrollableArea));
Comment 6 Csaba Osztrogonác 2016-03-08 23:13:19 PST
(In reply to comment #4)
> EFL port is still using scrollLayerForScrollableArea(). Why is this code
> dead ?

Because grep doesn't work on OS X and they don't have time to wait for EWS ...
Comment 7 Gyuyoung Kim 2016-03-08 23:23:11 PST
(In reply to comment #6)
> (In reply to comment #4)
> > EFL port is still using scrollLayerForScrollableArea(). Why is this code
> > dead ?
> 
> Because grep doesn't work on OS X and they don't have time to wait for EWS
> ...

I wonder if we can revert this patch for EFL port.
Comment 8 Csaba Osztrogonác 2016-03-08 23:29:11 PST
(In reply to comment #7)
> I wonder if we can revert this patch for EFL port.

It is not WebKit2 code, so theoretically you have the right to do it.
But I have a feeling that Apple will tell you, why you shouldn't do. :)
Comment 9 WebKit Commit Bot 2016-03-08 23:42:57 PST
Re-opened since this is blocked by bug 155222
Comment 10 Gyuyoung Kim 2016-03-08 23:46:11 PST
(In reply to comment #9)
> Re-opened since this is blocked by bug 155222

Myles, I revert this patch to restore the EFL build. If there is issues about my revert, please let me know.
Comment 11 Myles C. Maxfield 2016-03-09 15:35:43 PST
(In reply to comment #10)
> (In reply to comment #9)
> > Re-opened since this is blocked by bug 155222
> 
> Myles, I revert this patch to restore the EFL build. If there is issues
> about my revert, please let me know.

Sorry, I was relying on EWS to tell me if it was used, and EWS wasn't running the EFL build :(