Bug 155210 – Delete dead scrolling code

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

Delete dead scrolling code

[Myles C. Maxfield]

Created attachment 273369 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 273369 [details]
Patch

Clearing flags on attachment: 273369

Committed r197825: <http://trac.webkit.org/changeset/197825>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Gyuyoung Kim]

EFL port is still using scrollLayerForScrollableArea(). Why is this code dead ?

[Csaba Osztrogonác]

(In reply to comment #2)
> Comment on attachment 273369 [details]
> Patch
> 
> Clearing flags on attachment: 273369
> 
> Committed r197825: <http://trac.webkit.org/changeset/197825>

It broke the EFL build:

../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: In member function ‘virtual void WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange(WebCore::ScrollableArea&)’:
../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:99:109: error: ‘scrollLayerForScrollableArea’ was not declared in this scope
     CoordinatedGraphicsLayer* layer = toCoordinatedGraphicsLayer(scrollLayerForScrollableArea(scrollableArea));
                                                                                                             ^
../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: In member function ‘virtual void WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea(WebCore::ScrollableArea&)’:
../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:108:109: error: ‘scrollLayerForScrollableArea’ was not declared in this scope
     CoordinatedGraphicsLayer* layer = toCoordinatedGraphicsLayer(scrollLayerForScrollableArea(scrollableArea));

[Csaba Osztrogonác]

(In reply to comment #4)
> EFL port is still using scrollLayerForScrollableArea(). Why is this code
> dead ?

Because grep doesn't work on OS X and they don't have time to wait for EWS ...

[Gyuyoung Kim]

(In reply to comment #6)
> (In reply to comment #4)
> > EFL port is still using scrollLayerForScrollableArea(). Why is this code
> > dead ?
> 
> Because grep doesn't work on OS X and they don't have time to wait for EWS
> ...

I wonder if we can revert this patch for EFL port.

[Csaba Osztrogonác]

(In reply to comment #7)
> I wonder if we can revert this patch for EFL port.

It is not WebKit2 code, so theoretically you have the right to do it.
But I have a feeling that Apple will tell you, why you shouldn't do. :)

[WebKit Commit Bot]

Re-opened since this is blocked by bug 155222

[Gyuyoung Kim]

(In reply to comment #9)
> Re-opened since this is blocked by bug 155222

Myles, I revert this patch to restore the EFL build. If there is issues about my revert, please let me know.

[Myles C. Maxfield]

(In reply to comment #10)
> (In reply to comment #9)
> > Re-opened since this is blocked by bug 155222
> 
> Myles, I revert this patch to restore the EFL build. If there is issues
> about my revert, please let me know.

Sorry, I was relying on EWS to tell me if it was used, and EWS wasn't running the EFL build :(