Delete dead scrolling code
Created attachment 273369 [details] Patch
Comment on attachment 273369 [details] Patch Clearing flags on attachment: 273369 Committed r197825: <http://trac.webkit.org/changeset/197825>
All reviewed patches have been landed. Closing bug.
EFL port is still using scrollLayerForScrollableArea(). Why is this code dead ?
(In reply to comment #2) > Comment on attachment 273369 [details] > Patch > > Clearing flags on attachment: 273369 > > Committed r197825: <http://trac.webkit.org/changeset/197825> It broke the EFL build: ../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: In member function ‘virtual void WebCore::ScrollingCoordinatorCoordinatedGraphics::scrollableAreaScrollLayerDidChange(WebCore::ScrollableArea&)’: ../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:99:109: error: ‘scrollLayerForScrollableArea’ was not declared in this scope CoordinatedGraphicsLayer* layer = toCoordinatedGraphicsLayer(scrollLayerForScrollableArea(scrollableArea)); ^ ../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp: In member function ‘virtual void WebCore::ScrollingCoordinatorCoordinatedGraphics::willDestroyScrollableArea(WebCore::ScrollableArea&)’: ../../Source/WebCore/page/scrolling/coordinatedgraphics/ScrollingCoordinatorCoordinatedGraphics.cpp:108:109: error: ‘scrollLayerForScrollableArea’ was not declared in this scope CoordinatedGraphicsLayer* layer = toCoordinatedGraphicsLayer(scrollLayerForScrollableArea(scrollableArea));
(In reply to comment #4) > EFL port is still using scrollLayerForScrollableArea(). Why is this code > dead ? Because grep doesn't work on OS X and they don't have time to wait for EWS ...
(In reply to comment #6) > (In reply to comment #4) > > EFL port is still using scrollLayerForScrollableArea(). Why is this code > > dead ? > > Because grep doesn't work on OS X and they don't have time to wait for EWS > ... I wonder if we can revert this patch for EFL port.
(In reply to comment #7) > I wonder if we can revert this patch for EFL port. It is not WebKit2 code, so theoretically you have the right to do it. But I have a feeling that Apple will tell you, why you shouldn't do. :)
Re-opened since this is blocked by bug 155222
(In reply to comment #9) > Re-opened since this is blocked by bug 155222 Myles, I revert this patch to restore the EFL build. If there is issues about my revert, please let me know.
(In reply to comment #10) > (In reply to comment #9) > > Re-opened since this is blocked by bug 155222 > > Myles, I revert this patch to restore the EFL build. If there is issues > about my revert, please let me know. Sorry, I was relying on EWS to tell me if it was used, and EWS wasn't running the EFL build :(