Bug 155209 - CRASH at WebCore::RenderView::updateVisibleViewportRect
Summary: CRASH at WebCore::RenderView::updateVisibleViewportRect
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
: 155344 (view as bug list)
Depends on:
Blocks:
 
Reported: 2016-03-08 16:59 PST by Jer Noble
Modified: 2016-03-10 20:26 PST (History)
3 users (show)

See Also:


Attachments
Patch (4.83 KB, patch)
2016-03-08 20:31 PST, Jer Noble
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2016-03-08 16:59:21 PST
CRASH at WebCore::RenderView::updateVisibleViewportRect
Comment 1 Jer Noble 2016-03-08 16:59:44 PST
<rdar://problem/23997530>
Comment 2 Jer Noble 2016-03-08 20:31:28 PST
Created attachment 273382 [details]
Patch
Comment 3 Simon Fraser (smfr) 2016-03-08 21:21:58 PST
Comment on attachment 273382 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273382&action=review

> Source/WebCore/html/HTMLMediaElement.cpp:796
> +    if (renderer() && renderer()->isRegisteredForVisibleInViewportCallback())
>          renderer()->unregisterForVisibleInViewportCallback();

Would it be bad to just unconditionally call unregisterForVisibleInViewportCallback()?

> LayoutTests/media/video-crash-invisible-autoplay-display-none.html:11
> +            run('internals.setMediaElementRestrictions(video, "InvisibleAutoplayNotPermitted")');

This run() thing is weird. Does it just log and eval?
Comment 4 Jer Noble 2016-03-08 22:08:56 PST
(In reply to comment #3)
> Comment on attachment 273382 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273382&action=review
> 
> > Source/WebCore/html/HTMLMediaElement.cpp:796
> > +    if (renderer() && renderer()->isRegisteredForVisibleInViewportCallback())
> >          renderer()->unregisterForVisibleInViewportCallback();
> 
> Would it be bad to just unconditionally call
> unregisterForVisibleInViewportCallback()?

Not really, as unregister...() checks whether it's actually registered itself as well.

> > LayoutTests/media/video-crash-invisible-autoplay-display-none.html:11
> > +            run('internals.setMediaElementRestrictions(video, "InvisibleAutoplayNotPermitted")');
> 
> This run() thing is weird. Does it just log and eval?

Yep. I like that it shows what's going on in the results.
Comment 5 Jer Noble 2016-03-10 20:25:42 PST
Committed r197989: <http://trac.webkit.org/changeset/197989>
Comment 6 Jer Noble 2016-03-10 20:26:12 PST
*** Bug 155344 has been marked as a duplicate of this bug. ***