Bug 155203 – FunctionExecutable::ecmaName() should not be based on inferredName().

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Lam]

Currently, we're approximating ecmaName()'s behavior using the debugging inferredName of executables.  Will fix.

[Mark Lam]

The

[Radar WebKit Bug Importer]

<rdar://problem/25053826>

[Mark Lam]

The ES6 rules for how a function name should be inferred closely matches JSC's implementation with one exception:
    var o = {}
    o.foo = function() {}

JSC's inferredName for o.foo would be "foo".
ES6 specifies that o.foo.name is "".

The fix is to add a distinct FunctionExecutable::ecmaName() which applies the ES6 rules for inferring the initial value of Function.name.

[Mark Lam]

Created attachment 273394 [details]
proposed patch.

[Build Bot]

Comment on attachment 273394 [details]
proposed patch.

Attachment 273394 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/945691

New failing tests:
http/tests/media/media-source/mediasource-sourcebuffer-mode.html

[Build Bot]

Created attachment 273401 [details]
Archive of layout-test-results from ews103 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews103  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273394 [details]
proposed patch.

Attachment 273394 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/945706

New failing tests:
http/tests/media/media-source/mediasource-sourcebuffer-mode.html

[Build Bot]

Created attachment 273403 [details]
Archive of layout-test-results from ews106 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews106  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273394 [details]
proposed patch.

Attachment 273394 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/945783

New failing tests:
http/tests/media/media-source/mediasource-sourcebuffer-mode.html

[Build Bot]

Created attachment 273405 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Mark Lam]

Comment on attachment 273394 [details]
proposed patch.

Taking off review while I investigate test failures.

[Mark Lam]

Created attachment 273441 [details]
proposed patch: with rebased test result.

[WebKit Commit Bot]

Attachment 273441 [details] did not pass style-queue:


ERROR: LayoutTests/ChangeLog:10:  Need whitespace between colon and description  [changelog/filechangedescriptionwhitespace] [5]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Michael Saboff]

Comment on attachment 273441 [details]
proposed patch: with rebased test result.

r=me.  Add a comment in the place where you don't call setEcmaName() to comply with the standard.

[Mark Lam]

Thanks for the review.  Added requested comment and landed in r197867: <http://trac.webkit.org/197867>.