Bug 155191 - [GTK] Enable the SVG -> OTF Font Converter
Summary: [GTK] Enable the SVG -> OTF Font Converter
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Myles C. Maxfield
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-08 13:42 PST by Myles C. Maxfield
Modified: 2016-03-08 15:59 PST (History)
0 users

See Also:

Attachments
Patch (1.47 KB, patch)
2016-03-08 13:43 PST, Myles C. Maxfield 		mrobinson: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Myles C. Maxfield 2016-03-08 13:42:43 PST 
[GTK] Enable the SVG -> OTF Font Converter
Comment 1 Myles C. Maxfield 2016-03-08 13:43:03 PST 
Created attachment 273325 [details]
Patch
Comment 2 Martin Robinson 2016-03-08 14:23:48 PST 
Comment on attachment 273325 [details]
Patch

No objections from me and no one else said anything in the original thread, so I think we should go ahead with this. I'll watch the bots, which already have many failing tests.
Comment 3 Michael Catanzaro 2016-03-08 15:28:17 PST 
Comment on attachment 273325 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273325&action=review

I was expecting this to be some big project, rather than a one-liner. :)

Anyway, it's the start of a release cycle, so if anything breaks from this, we have plenty of time to fix it.

> Source/cmake/OptionsGTK.cmake:170
> +WEBKIT_OPTION_DEFAULT_PORT_VALUE(ENABLE_SVG_OTF_CONVERTER PRIVATE ON)

This is a list of settings for which the GTK port differs from the WebKit project default value, defined in WebKitFeatures.cmake.  Since the default value is ON, we should remove it from this list.
Comment 4 Myles C. Maxfield 2016-03-08 15:59:09 PST 
Committed r197814: <http://trac.webkit.org/changeset/197814>