Bug 155190 – Web Inspector: Add Heap domain start/stop tracking commands

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Add Heap domain start/stop tracking commands.

* NOTES
- start/stop should take a heap snapshot

[Radar WebKit Bug Importer]

<rdar://problem/25042708>

[Radar WebKit Bug Importer]

<rdar://problem/25042808>

[Joseph Pecoraro]

Created attachment 273327 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 273329 [details]
[PATCH] For Bots (Part 1 and 2)

[Joseph Pecoraro]

Created attachment 273354 [details]
[PATCH] For Bots (Part 1 and 2)

Better part 1 and 2 patch while this is blocked.

[Blaze Burg]

Comment on attachment 273327 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273327&action=review

r=me on the code. However I don't see the point of having start/stop with no update. What is being tracked exactly, memory pressure? allocations?

> Source/WebInspectorUI/UserInterface/Protocol/HeapObserver.js:39
> +        // FIXME: Heap Allocations Timeline.

Please delete or clean up the commented code for landing.

[Joseph Pecoraro]

(In reply to comment #6)
> Comment on attachment 273327 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273327&action=review
> 
> r=me on the code. However I don't see the point of having start/stop with no
> update. What is being tracked exactly, memory pressure? allocations?

Eventually there will be an update for tracking all allocations during the recording. That is separate from snapshots and I plan on working on that after the initial UI for snapshots makes it in.

[Joseph Pecoraro]

Created attachment 273370 [details]
[PATCH] For Landing

[Joseph Pecoraro]

<http://trac.webkit.org/changeset/197826>