Bug 155190 - Web Inspector: Add Heap domain start/stop tracking commands
Summary: Web Inspector: Add Heap domain start/stop tracking commands
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on: 155188
Blocks:
  Show dependency tree / graph
 
Reported: 2016-03-08 13:39 PST by Joseph Pecoraro
Modified: 2016-05-03 03:03 PDT (History)
12 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (9.80 KB, patch)
2016-03-08 13:43 PST, Joseph Pecoraro 		bburg: review+
Details | Formatted Diff | Diff
[PATCH] For Bots (Part 1 and 2) (29.75 KB, patch)
2016-03-08 13:44 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] For Bots (Part 1 and 2) (29.79 KB, patch)
2016-03-08 15:40 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
[PATCH] For Landing (9.62 KB, patch)
2016-03-08 17:59 PST, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-08 13:39:51 PST 
* SUMMARY
Add Heap domain start/stop tracking commands.

* NOTES
- start/stop should take a heap snapshot
Comment 1 Radar WebKit Bug Importer 2016-03-08 13:40:39 PST 
<rdar://problem/25042708>
Comment 2 Radar WebKit Bug Importer 2016-03-08 13:43:37 PST 
<rdar://problem/25042808>
Comment 3 Joseph Pecoraro 2016-03-08 13:43:41 PST 
Created attachment 273327 [details]
[PATCH] Proposed Fix
Comment 4 Joseph Pecoraro 2016-03-08 13:44:09 PST 
Created attachment 273329 [details]
[PATCH] For Bots (Part 1 and 2)
Comment 5 Joseph Pecoraro 2016-03-08 15:40:35 PST 
Created attachment 273354 [details]
[PATCH] For Bots (Part 1 and 2)

Better part 1 and 2 patch while this is blocked.
Comment 6 BJ Burg 2016-03-08 16:43:32 PST 
Comment on attachment 273327 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273327&action=review

r=me on the code. However I don't see the point of having start/stop with no update. What is being tracked exactly, memory pressure? allocations?

> Source/WebInspectorUI/UserInterface/Protocol/HeapObserver.js:39
> +        // FIXME: Heap Allocations Timeline.

Please delete or clean up the commented code for landing.
Comment 7 Joseph Pecoraro 2016-03-08 17:04:24 PST 
(In reply to comment #6)
> Comment on attachment 273327 [details]
> [PATCH] Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273327&action=review
> 
> r=me on the code. However I don't see the point of having start/stop with no
> update. What is being tracked exactly, memory pressure? allocations?

Eventually there will be an update for tracking all allocations during the recording. That is separate from snapshots and I plan on working on that after the initial UI for snapshots makes it in.
Comment 8 Joseph Pecoraro 2016-03-08 17:59:32 PST 
Created attachment 273370 [details]
[PATCH] For Landing
Comment 9 Joseph Pecoraro 2016-03-08 18:07:18 PST 
<http://trac.webkit.org/changeset/197826>