Bug 155179 – Array.isArray support for Proxy

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Saam Barati]

Array.isArray(new Proxy([], {})) should be true.

[Saam Barati]

Created attachment 273494 [details]
patch

[WebKit Commit Bot]

Attachment 273494 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/ArrayConstructor.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Mark Lam]

Comment on attachment 273494 [details]
patch

r=me

[Benjamin Poulain]

View in context: https://bugs.webkit.org/attachment.cgi?id=273494&action=review

> Source/JavaScriptCore/tests/stress/proxy-is-array.js:19
> +

It would be good to test 
    assert(Array.isArray(proxy));
before revoke()

> Source/JavaScriptCore/tests/stress/proxy-is-array.js:22
> +    try {

Don't we have shouldAssert()?

[Saam Barati]

Comment on attachment 273494 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273494&action=review

> Source/JavaScriptCore/runtime/ArrayConstructor.cpp:136
> +        JSValue::encode(jsBoolean(false));

Oops. This should obviously be a return.

[Saam Barati]

Created attachment 273504 [details]
for landing

[WebKit Commit Bot]

Attachment 273504 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/runtime/ArrayConstructor.cpp:36:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 273504 [details]
for landing

Clearing flags on attachment: 273504

Committed r197899: <http://trac.webkit.org/changeset/197899>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.