Bug 155158 – Web Inspector: Memory Timeline should show MemoryPressure events

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Joseph Pecoraro]

* SUMMARY
Memory Timeline should show MemoryPressure events.

* NOTES
- MemoryPressureHandler singleton handles pressure events
- Page::forEachPage([]{}) can be used to notify inspectors for the pages

[Radar WebKit Bug Importer]

<rdar://problem/25026610>

[Joseph Pecoraro]

Created attachment 273346 [details]
[PATCH] Proposed Fix

[Joseph Pecoraro]

Created attachment 273348 [details]
[IMAGE] Memory Pressure Event Marker in Memory Timeline

[Joseph Pecoraro]

I simulated a memory pressure event with:

    shell> sudo memory_pressure -S -l critical

[Joseph Pecoraro]

Comment on attachment 273346 [details]
[PATCH] Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273346&action=review

> Source/WebInspectorUI/UserInterface/Controllers/TimelineManager.js:63
> +            new WebInspector.MemoryInstrument,

Oops, not this.

[Joseph Pecoraro]

Created attachment 273349 [details]
[PATCH] Proposed Fix

[Build Bot]

Comment on attachment 273349 [details]
[PATCH] Proposed Fix

Attachment 273349 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.webkit.org/results/944019

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 273359 [details]
Archive of layout-test-results from ews102 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: ews102  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273349 [details]
[PATCH] Proposed Fix

Attachment 273349 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.webkit.org/results/944042

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 273360 [details]
Archive of layout-test-results from ews105 for mac-yosemite-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: ews105  Port: mac-yosemite-wk2  Platform: Mac OS X 10.10.5

[Build Bot]

Comment on attachment 273349 [details]
[PATCH] Proposed Fix

Attachment 273349 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/944037

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 273361 [details]
Archive of layout-test-results from ews112 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews112  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Joseph Pecoraro]

Created attachment 273362 [details]
[PATCH] Proposed Fix (Fix Tests)

[Blaze Burg]

Comment on attachment 273348 [details]
[IMAGE] Memory Pressure Event Marker in Memory Timeline

This is OK as engineering art. I think we should have something more distinctive eventually.

[Blaze Burg]

Comment on attachment 273362 [details]
[PATCH] Proposed Fix (Fix Tests)

View in context: https://bugs.webkit.org/attachment.cgi?id=273362&action=review

r=me

> Source/JavaScriptCore/inspector/protocol/Memory.json:26
> +            "name": "enable",

Is it necessary to run the enable command before taking snapshots? EDIT: oh, duh, this is a different agent. Disregard this.

> Source/WebCore/inspector/InspectorInstrumentation.h:431
> +    static void didHandleMemoryPressureImpl(InstrumentingAgents&, Critical);

I want to retroactively r- whoever added this context-free enum class name. >=(

> Source/WebCore/inspector/InspectorInstrumentation.h:1196
> +inline void InspectorInstrumentation::didHandleMemoryPressure(Page& page, Critical critical)

critical -> isCritical or something.

[Joseph Pecoraro]

Comment on attachment 273362 [details]
[PATCH] Proposed Fix (Fix Tests)

View in context: https://bugs.webkit.org/attachment.cgi?id=273362&action=review

>> Source/WebCore/inspector/InspectorInstrumentation.h:1196
>> +inline void InspectorInstrumentation::didHandleMemoryPressure(Page& page, Critical critical)
> 
> critical -> isCritical or something.

Going to ignore this since it isn't a boolean. All the MemoryPressureHandler code names it "critical" and I like matching that.

[WebKit Commit Bot]

Comment on attachment 273362 [details]
[PATCH] Proposed Fix (Fix Tests)

Rejecting attachment 273362 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-01', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 273362, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
0-ab3c-d52691b4dbfc ...
Currently at 197820 = 0db13d7220a3c8b9ab22e2bd40b9bf767db090c0
r197821 = 2a8a6bc6e847df7b164499211f5ab5350207a3a0
r197822 = eb056a793fe392727de2b3aed849415e5b758193
r197823 = b25c19ded5fd95602dc1baf1e8bf23779eddd53f
r197824 = 553053b7febf98223a545a54911f3ad91489f49d
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.webkit.org/results/944491

[Joseph Pecoraro]

<http://trac.webkit.org/changeset/197827>