Bug 155152 - [JSC] Small clean up of how we use SSA's valuesAtHead
Summary: [JSC] Small clean up of how we use SSA's valuesAtHead
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-07 18:55 PST by Benjamin Poulain
Modified: 2016-03-07 21:56 PST (History)
6 users (show)

See Also:

Attachments
Patch (3.31 KB, patch)
2016-03-07 18:57 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch for landing (3.22 KB, patch)
2016-03-07 20:57 PST, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2016-03-07 18:55:10 PST 
[JSC] Small clean up of how we use SSA's valuesAtHead
Comment 1 Benjamin Poulain 2016-03-07 18:57:16 PST 
Created attachment 273259 [details]
Patch
Comment 2 Filip Pizlo 2016-03-07 20:24:14 PST 
Comment on attachment 273259 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273259&action=review

> Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp:65
> +        for (auto& iter : basicBlock->ssa->valuesAtHead)

I would call it "entry" instead of "iter".

> Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp:302
> +        for (auto& valueAtHeadIterator : to->ssa->valuesAtHead) {

Ditto.  Maybe you could just call it "entry" here as well.
Comment 3 Benjamin Poulain 2016-03-07 20:57:24 PST 
Created attachment 273265 [details]
Patch for landing
Comment 4 WebKit Commit Bot 2016-03-07 21:56:42 PST 
Comment on attachment 273265 [details]
Patch for landing

Clearing flags on attachment: 273265

Committed r197725: <http://trac.webkit.org/changeset/197725>
Comment 5 WebKit Commit Bot 2016-03-07 21:56:46 PST 
All reviewed patches have been landed.  Closing bug.