WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155152
[JSC] Small clean up of how we use SSA's valuesAtHead
https://bugs.webkit.org/show_bug.cgi?id=155152
Summary
[JSC] Small clean up of how we use SSA's valuesAtHead
Benjamin Poulain
Reported
2016-03-07 18:55:10 PST
[JSC] Small clean up of how we use SSA's valuesAtHead
Attachments
Patch
(3.31 KB, patch)
2016-03-07 18:57 PST
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
Patch for landing
(3.22 KB, patch)
2016-03-07 20:57 PST
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2016-03-07 18:57:16 PST
Created
attachment 273259
[details]
Patch
Filip Pizlo
Comment 2
2016-03-07 20:24:14 PST
Comment on
attachment 273259
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=273259&action=review
> Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp:65 > + for (auto& iter : basicBlock->ssa->valuesAtHead)
I would call it "entry" instead of "iter".
> Source/JavaScriptCore/dfg/DFGInPlaceAbstractState.cpp:302 > + for (auto& valueAtHeadIterator : to->ssa->valuesAtHead) {
Ditto. Maybe you could just call it "entry" here as well.
Benjamin Poulain
Comment 3
2016-03-07 20:57:24 PST
Created
attachment 273265
[details]
Patch for landing
WebKit Commit Bot
Comment 4
2016-03-07 21:56:42 PST
Comment on
attachment 273265
[details]
Patch for landing Clearing flags on attachment: 273265 Committed
r197725
: <
http://trac.webkit.org/changeset/197725
>
WebKit Commit Bot
Comment 5
2016-03-07 21:56:46 PST
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug