Bug 155133 - CSP: Remove hardcoded directive names from ContentSecurityPolicySourceList::isProtocolAllowedByStar()
Summary: CSP: Remove hardcoded directive names from ContentSecurityPolicySourceList::i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on: 154122
Blocks:
  Show dependency tree / graph
 
Reported: 2016-03-07 14:12 PST by Daniel Bates
Modified: 2016-03-24 19:15 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2016-03-07 14:12:32 PST 
The patch for bug #154122 hardcoded the directive names "img-src" and "media-src" in the implementation of ContentSecurityPolicySourceList::isProtocolAllowedByStar(). Instead we should make use of the constants in ContentSecurityPolicyDirectiveList.cpp.
Comment 1 Daniel Bates 2016-03-24 11:06:43 PDT 
I will fix this bug as part of the refactoring in the patch for bug #155842.
Comment 2 Daniel Bates 2016-03-24 19:15:02 PDT 
Fixed in <http://trac.webkit.org/changeset/198657>.