Bug 155129 – [iOS] Arabic text on Wikipedia is shown as boxes

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Myles C. Maxfield]

[iOS] Arabic text on Wikipedia is shown as boxes

[Myles C. Maxfield]

Created attachment 273205 [details]
WIP

[Myles C. Maxfield]

Comment on attachment 273205 [details]
WIP

View in context: https://bugs.webkit.org/attachment.cgi?id=273205&action=review

> Source/WebCore/platform/graphics/ios/FontCacheIOS.mm:116
> +            fallbackFontDescriptor = adoptCF(CTFontDescriptorCreateMatchingFontDescriptor(adoptCF(CTFontDescriptorCreateWithAttributes(fallbackAttributes.get())).get(), nullptr));

Perhaps we should say the family name is a required attribute

[Myles C. Maxfield]

Created attachment 273344 [details]
Patch

[Myles C. Maxfield]

<rdar://problem/24919902>

[Myles C. Maxfield]

Comment on attachment 273344 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273344&action=review

> Source/WebCore/ChangeLog:4
> +        https://bugs.webkit.org/show_bug.cgi?id=155129

<rdar://problem/24919902>

[Myles C. Maxfield]

Created attachment 273357 [details]
Patch

[Darin Adler]

Comment on attachment 273357 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273357&action=review

> LayoutTests/ChangeLog:16
> +        * fast/text/arabic-blacklisted-expected.html: Added.
> +        * fast/text/arabic-blacklisted.html: Added.

Since the test is iOS-specific, the correct way to add it would be to put it somewhere inside platform/ios instead having all the other platforms ignore the test.

[Simon Fraser (smfr)]

We're trying to avoid putting tests in platform/, since people forget to run them, and they create results in platform/foo/platform/foo/thing directories. I think I mentioned this on webkit-dev.

[WebKit Commit Bot]

Comment on attachment 273357 [details]
Patch

Clearing flags on attachment: 273357

Committed r197847: <http://trac.webkit.org/changeset/197847>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Fujii Hironori]

Committed r253669: <https://trac.webkit.org/changeset/253669>