Bug 155126 - Last opened tab does not receive SetHiddenPageTimerThrottlingIncreaseLimit message
Summary: Last opened tab does not receive SetHiddenPageTimerThrottlingIncreaseLimit me...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on: 155252
Blocks:
  Show dependency tree / graph
 
Reported: 2016-03-07 11:47 PST by Gavin Barraclough
Modified: 2016-03-09 17:55 PST (History)
1 user (show)

See Also:

Attachments
Fix (3.04 KB, patch)
2016-03-07 11:50 PST, Gavin Barraclough 		cdumez: review+
Details | Formatted Diff | Diff
Fix (3.11 KB, patch)
2016-03-09 14:39 PST, Gavin Barraclough 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2016-03-07 11:47:46 PST 
WebPageProxy will increment the hidden page throttling counter from within its constructor, which currently causes the WebProcessPool to try to synchronously message all processes. The web page triggering the increment then fails to receive the message, since it was still being constructed. Make the update of the limit async, such that the page is fully constructed before the WebProcessPool processes the update.
Comment 1 Gavin Barraclough 2016-03-07 11:50:43 PST 
Created attachment 273199 [details]
Fix
Comment 2 Gavin Barraclough 2016-03-07 11:51:22 PST 
Comment on attachment 273199 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273199&action=review

> Source/WebKit2/ChangeLog:14
> +

One too many newlines!
Comment 3 Chris Dumez 2016-03-07 12:08:08 PST 
Comment on attachment 273199 [details]
Fix

r=me
Comment 4 Gavin Barraclough 2016-03-07 12:28:33 PST 
Transmitting file data ...
Committed revision 197698.
Comment 5 WebKit Commit Bot 2016-03-09 13:14:06 PST 
Re-opened since this is blocked by bug 155252
Comment 6 Gavin Barraclough 2016-03-09 14:39:33 PST 
Created attachment 273486 [details]
Fix
Comment 7 Gavin Barraclough 2016-03-09 17:55:30 PST 
Transmitting file data ...
Committed revision 197914.