Bug 155119 - REGRESSION(r197062): [GTK] Transparent backgrounds no longer work after r197062
Summary: REGRESSION(r197062): [GTK] Transparent backgrounds no longer work after r197062
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Keywords: Gtk, Regression
Depends on:
Reported: 2016-03-07 09:48 PST by Carlos Garcia Campos
Modified: 2016-03-07 23:18 PST (History)
6 users (show)

See Also:

Patch (3.72 KB, patch)
2016-03-07 09:52 PST, Carlos Garcia Campos
no flags Details | Formatted Diff | Diff
Fix coding style (3.72 KB, patch)
2016-03-07 09:56 PST, Carlos Garcia Campos
mrobinson: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-03-07 09:48:54 PST
Try running MiniBrowser --bg-color="rgba(255,0,0,0)" -e for example, you should see the web view transparent, but what we get now is black wen view instead. This is because after r197062 we are now realizing the view too early, even before the toplevel window has been realized, forcing the toplevel window to be realized. If the RGBA visual is set on the window after it has been realzied it doesn't have any effect. We should wait until the toplevel window is realized to realize the web view, giving time to the application to set RGBA visual and background color.
Comment 1 Carlos Garcia Campos 2016-03-07 09:52:41 PST
Created attachment 273191 [details]
Comment 2 WebKit Commit Bot 2016-03-07 09:54:16 PST
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2016-03-07 09:56:04 PST
Created attachment 273192 [details]
Fix coding style
Comment 4 Carlos Garcia Campos 2016-03-07 23:18:13 PST
Committed r197733: <http://trac.webkit.org/changeset/197733>