Bug 155113 - ElementRuleCollector should not mutate document and style
Summary: ElementRuleCollector should not mutate document and style
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-07 08:13 PST by Antti Koivisto
Modified: 2022-07-24 13:37 PDT (History)
8 users (show)

See Also:

Attachments
patch (93.10 KB, patch)
2016-03-07 09:11 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (92.88 KB, patch)
2016-03-07 09:21 PST, Antti Koivisto 		no flags Details | Formatted Diff | Diff
patch (92.91 KB, patch)
2016-03-07 09:45 PST, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-03-07 08:13:00 PST 
Move applying of style relations out of ElementRuleCollector and StyleResolver. This gets us closer to making StyleResolver const for Element.
Comment 1 Antti Koivisto 2016-03-07 09:11:52 PST 
Created attachment 273184 [details]
patch
Comment 2 WebKit Commit Bot 2016-03-07 09:13:41 PST 
Attachment 273184 [details] did not pass style-queue:


ERROR: Source/WebCore/style/StyleRelations.cpp:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Antti Koivisto 2016-03-07 09:21:34 PST 
Created attachment 273186 [details]
patch
Comment 4 WebKit Commit Bot 2016-03-07 09:23:11 PST 
Attachment 273186 [details] did not pass style-queue:


ERROR: Source/WebCore/style/StyleRelations.cpp:39:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Antti Koivisto 2016-03-07 09:45:05 PST 
Created attachment 273188 [details]
patch
Comment 6 WebKit Commit Bot 2016-03-07 09:46:48 PST 
Attachment 273188 [details] did not pass style-queue:


ERROR: Source/WebCore/style/StyleRelations.cpp:40:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 32 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Andreas Kling 2016-03-08 01:49:54 PST 
Comment on attachment 273188 [details]
patch

r=me
Comment 8 Ahmad Saleem 2022-07-24 11:53:59 PDT 
This landed as part of following:

https://github.com/WebKit/WebKit/commit/a83279bfdc4c0c700da87bea326c1c2dcacd2d11

and similarly another commit landed:

https://github.com/WebKit/WebKit/commit/af23f8e0eb231b6cd22904c6511993e33651083a

I think this can be marked as "RESOLVED FIXED". Thanks!