Bug 155104 – [JSC] Improve and64() and or64() with immediate on x86

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Benjamin Poulain]

[JSC] Improve and64() and or64() with immediate on x86

[Benjamin Poulain]

Created attachment 273165 [details]
Patch

[Geoffrey Garen]

Comment on attachment 273165 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 273165 [details]
Patch

Clearing flags on attachment: 273165

Committed r197695: <http://trac.webkit.org/changeset/197695>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 273165 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273165&action=review

> Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:350
> +        if (intValue <= std::numeric_limits<int32_t>::max()
> +            && intValue >= std::numeric_limits<int32_t>::min()) {

Isn’t it more obvious to write it like this?

    if (intValue == static_cast<int32_t>(intValue))

[Benjamin Poulain]

(In reply to comment #5)
> Comment on attachment 273165 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273165&action=review
> 
> > Source/JavaScriptCore/assembler/MacroAssemblerX86_64.h:350
> > +        if (intValue <= std::numeric_limits<int32_t>::max()
> > +            && intValue >= std::numeric_limits<int32_t>::min()) {
> 
> Isn’t it more obvious to write it like this?
> 
>     if (intValue == static_cast<int32_t>(intValue))

That's how I originally wrote it but I thought the more verbose version was making the intent more obvious.