Bug 155102 – Web Inspector: It should be possible to initialize generated ObjC protocol types from an NSDictionary payload

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Blaze Burg]

Generate this.

[Radar WebKit Bug Importer]

<rdar://problem/25002015>

[Blaze Burg]

Created attachment 273163 [details]
Proposed Fix

[WebKit Commit Bot]

This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)

[Timothy Hatcher]

Comment on attachment 273163 [details]
Proposed Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=273163&action=review

> Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:124
> +        lines.append('')

You should drop this. It leads to two newlines in a row.

> Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:1462
> +
> +

This should be one newline. See above.

[Blaze Burg]

Created attachment 273187 [details]
For Landing

[Blaze Burg]

(In reply to comment #4)
> Comment on attachment 273163 [details]
> Proposed Fix
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=273163&action=review
> 
> > Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:124
> > +        lines.append('')
> 
> You should drop this. It leads to two newlines in a row.
> 
> > Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:1462
> > +
> > +
> 
> This should be one newline. See above.

Ok. I also guarded this new method so it's only generated when we pass '--frontend' to the generator, and rebaselined.

[WebKit Commit Bot]

Attachment 273187 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_header.py:164:  [ObjCHeaderGenerator._generate_type_interface] Instance of 'ObjCHeaderGenerator' has no 'get_generator_setting' member  [pylint/E1101] [5]
ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_types_implementation.py:94:  [ObjCProtocolTypesImplementationGenerator.generate_type_implementation] Instance of 'ObjCProtocolTypesImplementationGenerator' has no 'get_generator_setting' member  [pylint/E1101] [5]
Total errors found: 2 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[WebKit Commit Bot]

Comment on attachment 273187 [details]
For Landing

Clearing flags on attachment: 273187

Committed r197689: <http://trac.webkit.org/changeset/197689>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.