Created attachment 273163 [details]
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
Comment on attachment 273163 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=273163&action=review
> + lines.append('')
You should drop this. It leads to two newlines in a row.
This should be one newline. See above.
Created attachment 273187 [details]
(In reply to comment #4)
> Comment on attachment 273163 [details]
> Proposed Fix
> View in context:
> > + lines.append('')
> You should drop this. It leads to two newlines in a row.
> > +
> > +
> This should be one newline. See above.
Ok. I also guarded this new method so it's only generated when we pass '--frontend' to the generator, and rebaselined.
Attachment 273187 [details] did not pass style-queue:
Total errors found: 2 in 11 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 273187 [details]
Clearing flags on attachment: 273187
Committed r197689: <http://trac.webkit.org/changeset/197689>
All reviewed patches have been landed. Closing bug.