RESOLVED FIXED 155101
Web Inspector: the protocol generator should have separate prefix options for Objective-C classes and filenames 
https://bugs.webkit.org/show_bug.cgi?id=155101
Summary Web Inspector: the protocol generator should have separate prefix options for...
Blaze Burg
Reported 2016-03-06 17:07:46 PST
The 'Automation' prefix currently used is redundant with the only domain, 'Automation'.
Attachments
Proposed Fix (17.59 KB, patch)
2016-03-06 19:28 PST, Blaze Burg 		timothy: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2016-03-06 17:07:59 PST
<rdar://problem/25000053>
Blaze Burg
Comment 2 2016-03-06 19:28:49 PST
Created attachment 273159 [details] Proposed Fix
WebKit Commit Bot
Comment 3 2016-03-06 19:30:26 PST
This patch modifies the inspector protocol generator. Please ensure that you have rebaselined any generator test results (i.e., by running `Tools/Scripts/run-inspector-generator-tests --reset-results`)
WebKit Commit Bot
Comment 4 2016-03-06 19:30:33 PST
Attachment 273159 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_conversion_helpers.py:51: [ObjCConversionHelpersGenerator.output_filename] Instance of 'ObjCConversionHelpersGenerator' has no 'protocol_name' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:97: [ObjCGenerator.protocol_name] Instance of 'ObjCGenerator' has no 'model' member [pylint/E1101] [5] ERROR: Source/JavaScriptCore/inspector/scripts/codegen/objc_generator.py:103: [ObjCGenerator.objc_prefix] Instance of 'ObjCGenerator' has no 'model' member [pylint/E1101] [5] Total errors found: 3 in 12 files If any of these errors are false positives, please file a bug against check-webkit-style.
Blaze Burg
Comment 5 2016-03-06 19:52:10 PST
Committed r197658: <http://trac.webkit.org/changeset/197658>
Note You need to log in before you can comment on or make changes to this bug.