Bug 155094 – DFG should know how to speculate StringOrOther

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Filip Pizlo]

Patch forthcoming.

[Filip Pizlo]

Created attachment 273140 [details]
work in progress

[Filip Pizlo]

Created attachment 273141 [details]
it might be done

[Filip Pizlo]

Created attachment 273143 [details]
the patch

[WebKit Commit Bot]

Attachment 273143 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGNode.h:1964:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Saam Barati]

Comment on attachment 273143 [details]
the patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273143&action=review

r=me

> Source/JavaScriptCore/ChangeLog:17
> +        To do this, I needed to introduce code into the FTL that creates new blocks. We still had that
> +        awful FTL_NEW_BLOCK idiom since the only way to debug LLVM IR was to ascribe names to basic
> +        blocks. B3 IR is inherently more debuggable since unlike LLVM, B3 knows how to always respect
> +        code origin, and it knows how to print the code origin nicely in the dumps. So, rather than
> +        continue using FTL_NEW_BLOCK(m_out, ("things")), I replaced all of that stuff with
> +        m_out.newBlock(). It's much nicer that way.

Nice!

[Build Bot]

Comment on attachment 273143 [details]
the patch

Attachment 273143 [details] did not pass mac-debug-ews (mac):
Output: http://webkit-queues.webkit.org/results/933202

Number of test failures exceeded the failure limit.

[Build Bot]

Created attachment 273146 [details]
Archive of layout-test-results from ews115 for mac-yosemite

The attached test failures were seen while running run-webkit-tests on the mac-debug-ews.
Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

[Filip Pizlo]

(In reply to comment #7)
> Created attachment 273146 [details]
> Archive of layout-test-results from ews115 for mac-yosemite
> 
> The attached test failures were seen while running run-webkit-tests on the
> mac-debug-ews.
> Bot: ews115  Port: mac-yosemite  Platform: Mac OS X 10.10.5

Looks like I forgot to use ManualOperandSpeculation in some places.

[Filip Pizlo]

Created attachment 273154 [details]
patch for landing

This should resolve the debug test failures.

[WebKit Commit Bot]

Attachment 273154 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGNode.h:1964:  Weird number of spaces at line-start.  Are you using a 4-space indent?  [whitespace/indent] [3]
Total errors found: 1 in 15 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Filip Pizlo]

Landed in http://trac.webkit.org/changeset/197649