[JSC] StringObject.{put, defineOwnProperty} should realize indexed properties
Created attachment 273136 [details] Patch
Comment on attachment 273136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273136&action=review Added comment. > Source/JavaScriptCore/runtime/StringObject.cpp:72 > + return JSObject::put(cell, exec, propertyName, value, slot); Later, in Reflect.set patch, we return boolean from ::put, ::putByIndex. So now, we take the style like above.
Comment on attachment 273136 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=273136&action=review > Source/JavaScriptCore/runtime/StringObject.cpp:113 > + return validateAndApplyPropertyDescriptor(exec, nullptr, propertyName, isExtensible, descriptor, isCurrentDefined, current, throwException); When passing nullptr to validateAndApplyPropertyDescriptor, it just performs validation. This is OK since we know any descriptor cannot change the result. All we need is the returned value of the validation phase. And we note that this path is very very rare path. So performing slow / generic operation here causes no problem.
Comment on attachment 273136 [details] Patch r=me
Comment on attachment 273136 [details] Patch Clearing flags on attachment: 273136 Committed r197684: <http://trac.webkit.org/changeset/197684>
All reviewed patches have been landed. Closing bug.