Bug 155089 – [JSC] StringObject.{put, defineOwnProperty} should realize indexed properties

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Yusuke Suzuki]

[JSC] StringObject.{put, defineOwnProperty} should realize indexed properties

[Yusuke Suzuki]

Created attachment 273136 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 273136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273136&action=review

Added comment.

> Source/JavaScriptCore/runtime/StringObject.cpp:72
> +    return JSObject::put(cell, exec, propertyName, value, slot);

Later, in Reflect.set patch, we return boolean from ::put, ::putByIndex. So now, we take the style like above.

[Yusuke Suzuki]

Comment on attachment 273136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=273136&action=review

> Source/JavaScriptCore/runtime/StringObject.cpp:113
> +        return validateAndApplyPropertyDescriptor(exec, nullptr, propertyName, isExtensible, descriptor, isCurrentDefined, current, throwException);

When passing nullptr to validateAndApplyPropertyDescriptor, it just performs validation.
This is OK since we know any descriptor cannot change the result.
All we need is the returned value of the validation phase.

And we note that this path is very very rare path. So performing slow / generic operation here causes no problem.

[Geoffrey Garen]

Comment on attachment 273136 [details]
Patch

r=me

[WebKit Commit Bot]

Comment on attachment 273136 [details]
Patch

Clearing flags on attachment: 273136

Committed r197684: <http://trac.webkit.org/changeset/197684>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.