Bug 155085 - Convert DOMTimer to std::chrono::milliseconds
Summary: Convert DOMTimer to std::chrono::milliseconds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-06 00:23 PST by Gavin Barraclough
Modified: 2016-03-07 10:41 PST (History)
4 users (show)

See Also:

Attachments
Fix (26.56 KB, patch)
2016-03-06 00:36 PST, Gavin Barraclough 		no flags Details | Formatted Diff | Diff
Fix (27.95 KB, patch)
2016-03-06 22:22 PST, Gavin Barraclough 		no flags Details | Formatted Diff | Diff
Fix (28.20 KB, patch)
2016-03-06 23:33 PST, Gavin Barraclough 		kling: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2016-03-06 00:23:09 PST 
DOMTimer currently uses a mix of millisecond (was int, now std::chrono) and second (as double) time values. Constant conversion back and forth is a complete mess. Stop that.
Comment 1 Gavin Barraclough 2016-03-06 00:36:00 PST 
Created attachment 273129 [details]
Fix
Comment 2 Gavin Barraclough 2016-03-06 22:22:34 PST 
Created attachment 273161 [details]
Fix
Comment 3 Gavin Barraclough 2016-03-06 23:33:54 PST 
Created attachment 273164 [details]
Fix
Comment 4 Andreas Kling 2016-03-07 01:45:59 PST 
Comment on attachment 273164 [details]
Fix

r=me, sweet
Comment 5 Gavin Barraclough 2016-03-07 10:41:53 PST 
Transmitting file data ..................
Committed revision 197690.