Bug 155084 - Create a DOMHTMLVideoElement when wrapping <video> elements
Summary: Create a DOMHTMLVideoElement when wrapping <video> elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-05 20:50 PST by Tim Horton
Modified: 2016-03-18 08:42 PDT (History)
7 users (show)

See Also:


Attachments
Patch (1.64 KB, patch)
2016-03-05 20:51 PST, Tim Horton
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-03-05 20:50:54 PST
Create a DOMHTMLVideoElement when wrapping <video> elements
Comment 1 Tim Horton 2016-03-05 20:51:26 PST
Created attachment 273124 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2016-03-05 20:53:01 PST
<rdar://problem/24997193>
Comment 3 mitz 2016-03-05 20:53:19 PST
Comment on attachment 273124 [details]
Patch

This seems API-testable
Comment 4 Tim Horton 2016-03-05 20:55:17 PST
Sure, I suppose it is.
Comment 5 Tim Horton 2016-03-05 21:02:55 PST
http://trac.webkit.org/changeset/197633
Comment 6 Csaba Osztrogonác 2016-03-07 13:33:56 PST
(In reply to comment #5)
> http://trac.webkit.org/changeset/197633

It broke the Apple Mac cmake build:

/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:36:9: fatal error: 'DOMHTMLVideoElement.h' file not found
#import "DOMHTMLVideoElement.h"
        ^
Comment 7 Alex Christensen 2016-03-09 15:33:49 PST
r197892 should fix that.
Comment 8 Csaba Osztrogonác 2016-03-10 09:03:56 PST
(In reply to comment #7)
> r197892 should fix that.

No, it didn't fix.

/Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:59:9: fatal error: 'DOMHTMLVideoElement.h' file not found
#import "DOMHTMLVideoElement.h"
        ^
1 error generated.
Comment 9 Csaba Osztrogonác 2016-03-18 00:55:01 PDT
(In reply to comment #8)
> (In reply to comment #7)
> > r197892 should fix that.
> 
> No, it didn't fix.
> 
> /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/
> DOM.mm:59:9: fatal error: 'DOMHTMLVideoElement.h' file not found
> #import "DOMHTMLVideoElement.h"
>         ^
> 1 error generated.

Still broken due to this error.
Comment 10 Csaba Osztrogonác 2016-03-18 06:47:57 PDT
one more fix landed in http://trac.webkit.org/changeset/198397,
but the build is still broken:

In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/DOM.mm:59:
/Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/DerivedSources/WebCore/DOMHTMLVideoElement.h:27:9: fatal error: 'WebCore/DOMHTMLMediaElement.h' file not found
#import <WebCore/DOMHTMLMediaElement.h>
        ^
1 error generated.
Comment 11 Csaba Osztrogonác 2016-03-18 08:06:01 PDT
(In reply to comment #10)
> one more fix landed in http://trac.webkit.org/changeset/198397,
> but the build is still broken:
> 
> In file included from
> /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/bindings/objc/
> DOM.mm:59:
> /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/
> DerivedSources/WebCore/DOMHTMLVideoElement.h:27:9: fatal error:
> 'WebCore/DOMHTMLMediaElement.h' file not found
> #import <WebCore/DOMHTMLMediaElement.h>
>         ^
> 1 error generated.

More fixes landed in
- http://trac.webkit.org/changeset/198398
- http://trac.webkit.org/changeset/198400
but the build is still broken ...