Bug 155078 - build-webkit prints an error on iOS simulator bots
Summary: build-webkit prints an error on iOS simulator bots
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Reported: 2016-03-05 16:58 PST by Alexey Proskuryakov
Modified: 2016-03-06 00:33 PST (History)
7 users (show)

See Also:

naive fix (2.29 KB, patch)
2016-03-05 20:07 PST, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2016-03-05 16:58:35 PST

perl Tools/Scripts/copy-webkitlibraries-to-product-directory --sdk iphonesimulator --wksi /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator
Updating /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator/libWebKitSystemInterfaceIOSDevice9.0.a
Updating /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator/libWebKitSystemInterfaceIOSSimulator9.0.a
Updating /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator/libWebKitSystemInterfaceIOSDevice9.2.a
Updating /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator/libWebKitSystemInterfaceIOSSimulator9.2.a
Updating /Volumes/Data/slave/ios-simulator-9-debug/build/WebKitBuild/Debug-iphonesimulator/usr/local/include/WebKitSystemInterface.h
Use of uninitialized value $extraOptions[8] in system at /Volumes/Data/slave/ios-simulator-9-debug/build/Tools/Scripts/webkitdirs.pm line 1754.
Comment 1 Alexey Proskuryakov 2016-03-05 17:49:32 PST
xcodeSDK() returns an uninitialized value.
Comment 2 Alexey Proskuryakov 2016-03-05 17:57:49 PST
main::setXcodeSDK(undef) called at Tools/Scripts/build-layouttestrelay line 63
Comment 3 Alexey Proskuryakov 2016-03-05 18:58:08 PST
This is easy to fix by checking xcodeSDK() for undefined in buildXCodeProject():

    push(@extraOptions, ("-sdk", xcodeSDK())) if isIOSWebKit();

But I'm trying to understand why -sdk is added in buildXCodeProject() in the first place, not in XcodeOptions().
Comment 4 Alexey Proskuryakov 2016-03-05 20:07:42 PST
Created attachment 273120 [details]
naive fix

I don't quite understand the relationship between -sdk and SDKROOT, but looks like we don't need -sdk.
Comment 5 WebKit Commit Bot 2016-03-06 00:33:20 PST
Comment on attachment 273120 [details]
naive fix

Clearing flags on attachment: 273120

Committed r197636: <http://trac.webkit.org/changeset/197636>
Comment 6 WebKit Commit Bot 2016-03-06 00:33:25 PST
All reviewed patches have been landed.  Closing bug.