Bug 155077 - [GTK] Web Inspector: Add new GTK+ icons for different Script Timeline Views (Events and Call Trees)
Summary: [GTK] Web Inspector: Add new GTK+ icons for different Script Timeline Views (...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: DoNotImportToRadar
Depends on: 155075
Blocks:
  Show dependency treegraph
 
Reported: 2016-03-05 16:56 PST by Joseph Pecoraro
Modified: 2017-04-27 22:20 PDT (History)
11 users (show)

See Also:


Attachments
Patch (4.56 KB, patch)
2017-04-27 21:07 PDT, Fujii Hironori
no flags Details | Formatted Diff | Diff
screenshot of before and after this fix (31.64 KB, image/png)
2017-04-27 21:18 PDT, Fujii Hironori
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2016-03-05 16:56:21 PST
* SUMMARY
Add new GTK+ icons for different Script Timeline Views (Events and Call Trees).

- Events.svg
- CallTrees.svg

Mac icons were based off of ResultLine.svg, so that is what we currently fallback to on GTK.
Comment 1 Fujii Hironori 2017-04-27 21:07:48 PDT
Created attachment 308497 [details]
Patch
Comment 2 Joseph Pecoraro 2017-04-27 21:14:50 PDT
Comment on attachment 308497 [details]
Patch

These look fantastic! r=me
Comment 3 Joseph Pecoraro 2017-04-27 21:15:48 PDT
Comment on attachment 308497 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=308497&action=review

> Source/WebInspectorUI/UserInterface/Images/gtk/CallTrees.svg:7
> + <rect width="8.1401" height="1.9388" x="2.2201" y="2.9519" fill="#8f918c" rx="0.5" ry=".5"/>
> + <rect width="7.5399" height="1.9388" x="5.0149" y="7.0324" fill="#8f918c" rx=".5" ry=".5"/>
> + <rect width="5.5891" height="1.9388" x="8.2412" y="11.113" fill="#8f918c" rx="0.5" ry=".5"/>

Weird that sometimes there is "0.5" and other times there are just ".5". You may want to make them consistent.
Comment 4 Fujii Hironori 2017-04-27 21:18:51 PDT
Created attachment 308498 [details]
screenshot of before and after this fix
Comment 5 Fujii Hironori 2017-04-27 22:04:37 PDT
Thank you for the review.

(In reply to Joseph Pecoraro from comment #3)
> Weird that sometimes there is "0.5" and other times there are just ".5". You
> may want to make them consistent.

Andres's script optimizing.sh uses scour and svgo.
There two problems:

* scour 0.3 produces this inconsistent values
* Andres specifies cleanupNumericValues:false to svgo

To solve this, 
1) Use the latest scour
2) Or, specify cleanupNumericValues:true
Comment 6 Michael Catanzaro 2017-04-27 22:05:42 PDT
Thank you for your help with maintaining the web inspector icons! We had been worried about what to do when Andres stopped maintaining them.
Comment 7 WebKit Commit Bot 2017-04-27 22:20:38 PDT
Comment on attachment 308497 [details]
Patch

Clearing flags on attachment: 308497

Committed r215920: <http://trac.webkit.org/changeset/215920>
Comment 8 WebKit Commit Bot 2017-04-27 22:20:40 PDT
All reviewed patches have been landed.  Closing bug.