WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
155061
Move QualifiedName from CustomElementInfo to JSCustomElementInterface
https://bugs.webkit.org/show_bug.cgi?id=155061
Summary
Move QualifiedName from CustomElementInfo to JSCustomElementInterface
Ryosuke Niwa
Reported
2016-03-05 00:02:12 PST
Now that each custom element interface can be associated with exactly one custom element, there is no need to separate the interface object from the qualified name. Just store the associated qualified name in JSCustomElementInterface itself for simplicity.
Attachments
Cleanup
(10.73 KB, patch)
2016-03-05 00:13 PST
,
Ryosuke Niwa
koivisto
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2016-03-05 00:13:03 PST
Created
attachment 273069
[details]
Cleanup
Ryosuke Niwa
Comment 2
2016-03-05 00:29:15 PST
Comment on
attachment 273069
[details]
Cleanup View in context:
https://bugs.webkit.org/attachment.cgi?id=273069&action=review
> Source/WebCore/dom/CustomElementDefinitions.cpp:-74 > - ASSERT(!m_nameMap.contains(fullName.localName()));
Putting this assertion back per IRC discussion with kling & anttik.
Ryosuke Niwa
Comment 3
2016-03-05 00:31:27 PST
Committed
r197612
: <
http://trac.webkit.org/changeset/197612
>
Alexey Proskuryakov
Comment 4
2016-03-05 14:37:00 PST
Either this or
r197611
has caused memory corruption crashes on ASan and GuardMalloc bots. Ryosuke, are you around to take a look now?
Ryosuke Niwa
Comment 5
2016-03-05 16:24:50 PST
(In reply to
comment #4
)
> Either this or
r197611
has caused memory corruption crashes on ASan and > GuardMalloc bots. > > Ryosuke, are you around to take a look now?
Do you know a link or the name of a test on which the crash happens?
Ryosuke Niwa
Comment 6
2016-03-05 17:23:45 PST
(In reply to
comment #4
)
> Either this or
r197611
has caused memory corruption crashes on ASan and > GuardMalloc bots. > > Ryosuke, are you around to take a look now?
Fixed in
http://trac.webkit.org/changeset/197624
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug