Bug 155061 - Move QualifiedName from CustomElementInfo to JSCustomElementInterface
Summary: Move QualifiedName from CustomElementInfo to JSCustomElementInterface
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords:
Depends on:
Blocks: 154907
  Show dependency tree / graph
 
Reported: 2016-03-05 00:02 PST by Ryosuke Niwa
Modified: 2016-03-05 17:23 PST (History)
5 users (show)

See Also:

Attachments
Cleanup (10.73 KB, patch)
2016-03-05 00:13 PST, Ryosuke Niwa 		koivisto: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2016-03-05 00:02:12 PST 
Now that each custom element interface can be associated with exactly one custom element,
there is no need to separate the interface object from the qualified name.

Just store the associated qualified name in JSCustomElementInterface itself for simplicity.
Comment 1 Ryosuke Niwa 2016-03-05 00:13:03 PST 
Created attachment 273069 [details]
Cleanup
Comment 2 Ryosuke Niwa 2016-03-05 00:29:15 PST 
Comment on attachment 273069 [details]
Cleanup

View in context: https://bugs.webkit.org/attachment.cgi?id=273069&action=review

> Source/WebCore/dom/CustomElementDefinitions.cpp:-74
> -    ASSERT(!m_nameMap.contains(fullName.localName()));

Putting this assertion back per IRC discussion with kling & anttik.
Comment 3 Ryosuke Niwa 2016-03-05 00:31:27 PST 
Committed r197612: <http://trac.webkit.org/changeset/197612>
Comment 4 Alexey Proskuryakov 2016-03-05 14:37:00 PST 
Either this or r197611 has caused memory corruption crashes on ASan and GuardMalloc bots.

Ryosuke, are you around to take a look now?
Comment 5 Ryosuke Niwa 2016-03-05 16:24:50 PST 
(In reply to comment #4)
> Either this or r197611 has caused memory corruption crashes on ASan and
> GuardMalloc bots.
> 
> Ryosuke, are you around to take a look now?

Do you know a link or the name of a test on which the crash happens?
Comment 6 Ryosuke Niwa 2016-03-05 17:23:45 PST 
(In reply to comment #4)
> Either this or r197611 has caused memory corruption crashes on ASan and
> GuardMalloc bots.
> 
> Ryosuke, are you around to take a look now?

Fixed in http://trac.webkit.org/changeset/197624.