Bug 155046 - Begin implementing <attachment> painting on iOS
Summary: Begin implementing <attachment> painting on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-04 14:26 PST by Tim Horton
Modified: 2016-03-04 23:31 PST (History)
6 users (show)

See Also:

Attachments
Patch (16.81 KB, patch)
2016-03-04 14:26 PST, Tim Horton 		enrica: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2016-03-04 14:26:00 PST 
Begin implementing <attachment> painting on iOS
Comment 1 Tim Horton 2016-03-04 14:26:29 PST 
Created attachment 273042 [details]
Patch
Comment 2 WebKit Commit Bot 2016-03-04 14:28:44 PST 
Attachment 273042 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/RenderThemeIOS.h:115:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]
ERROR: Source/WebCore/rendering/RenderThemeIOS.h:116:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]
ERROR: Source/WebCore/rendering/RenderThemeIOS.h:117:  "virtual" is redundant since function is already declared as "override"  [readability/inheritance] [4]
Total errors found: 3 in 3 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2016-03-04 16:57:22 PST 
http://trac.webkit.org/changeset/197600
Comment 5 Tim Horton 2016-03-04 23:21:43 PST 
(In reply to comment #4)
> Could you please fix the tests?
> 
> https://build.webkit.org/results/
> Apple%20iOS%209%20Simulator%20Release%20WK2%20(Tests)/r197608%20(3666)/
> results.html

Oh, weird! As I noted in the ChangeLog, I thought they were skipped. Maybe I had the directory name wrong. Will fix!
Comment 6 Tim Horton 2016-03-04 23:31:47 PST 
Temporarily skipped in 197610. Next week there will be another <attachment> patch that completes the implementation and turns the tests back on.

Also, are ref tests upside-down?! :D