Bug 15504 - Fix crashers in SVGViewSpec::parseViewSpec
Summary: Fix crashers in SVGViewSpec::parseViewSpec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 523.x (Safari 3)
Hardware: Macintosh OS X 10.4
: P2 Normal
Assignee: Eric Seidel (no email)
URL:
Keywords:
Depends on: 15503
Blocks: 15495
  Show dependency treegraph
 
Reported: 2007-10-14 02:06 PDT by Eric Seidel (no email)
Modified: 2007-10-18 00:40 PDT (History)
0 users

See Also:


Attachments
fix for crashers (and includes missing idl file) (7.85 KB, patch)
2007-10-14 02:09 PDT, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2007-10-14 02:06:11 PDT
Fix crashers in SVGViewSpec::parseViewSpec

I'm also including the idl for SVGViewSpec as well as a tiny change in the JS bindings generator (it didn't handle multi-parent classes where all parents are just interfaces... which will eventually be needed by SVGViewSpec.idl for generation).  There are other bugs yet to resolve before we can turn on SVGViewSpec generation however.
Comment 1 Eric Seidel (no email) 2007-10-14 02:06:51 PDT
Unfortunately enabling the layout test I built for this is blocked by bug 15503.
Comment 2 Eric Seidel (no email) 2007-10-14 02:09:05 PDT
Created attachment 16664 [details]
fix for crashers (and includes missing idl file)
Comment 3 Maciej Stachowiak 2007-10-14 13:20:54 PDT
Comment on attachment 16664 [details]
fix for crashers (and includes missing idl file)

This looks ok, but as discussed let's find an alternate way to make the test work, or at least land it disabled and/or as a manual test.
Comment 4 Eric Seidel (no email) 2007-10-18 00:40:46 PDT
One more set of repro crashers down!  r26740