JavaScriptCore ASan build fails due to weak external symbol: PhaseScriptExecution Check For Weak VTables and Externals ERROR: JavaScriptCore has a weak external symbol in it (/Volumes/Data/BuildSlave/Monarch-WebKitASan/build/OpenSource/WebKitBuild/Debug-iphonesimulator/JavaScriptCore.framework/JavaScriptCore) ERROR: A weak external symbol is generated when a symbol is defined in multiple compilation units and is also marked as being exported from the library. ERROR: A common cause of weak external symbols is when an inline function is listed in the linker export file. ERROR: symbol __ZNK3JSC8JSObject19ordinaryToPrimitiveEPNS_9ExecStateENS_22PreferredPrimitiveTypeE This regressed with: Bug 154877: [ES6] Add support for Symbol.toPrimitive <https://bugs.webkit.org/show_bug.cgi?id=154877> <http://trac.webkit.org/changeset/197531>
<rdar://problem/24979661>
Created attachment 273026 [details] Patch v1
Comment on attachment 273026 [details] Patch v1 No cq+, since EWS is not done yet.
(In reply to comment #3) > Comment on attachment 273026 [details] > Patch v1 > > No cq+, since EWS is not done yet. Huh? EWS doesn't wait for in-flight builds to finish?
No, it never did. It would try to build itself, but only one configuration.
Comment on attachment 273026 [details] Patch v1 Clearing flags on attachment: 273026 Committed r197590: <http://trac.webkit.org/changeset/197590>
All reviewed patches have been landed. Closing bug.