Bug 154998 - Stub API to support a debug menu option for measuring resource load statistics
Summary: Stub API to support a debug menu option for measuring resource load statistics
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2016-03-03 17:46 PST by Brent Fulgham
Modified: 2016-03-04 16:40 PST (History)
3 users (show)

See Also:

Attachments
Patch (4.07 KB, patch)
2016-03-03 17:49 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch (v2) (4.32 KB, patch)
2016-03-04 14:43 PST, Brent Fulgham 		aestes: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2016-03-03 17:46:13 PST 
Add a stub preference implementation to allow client applications to activate/deactivate the resource load statistics gathering.
Comment 1 Brent Fulgham 2016-03-03 17:46:35 PST 
<rdar://problem/24944604>
Comment 2 Brent Fulgham 2016-03-03 17:49:45 PST 
Created attachment 272811 [details]
Patch
Comment 3 Brent Fulgham 2016-03-04 14:43:28 PST 
Created attachment 273046 [details]
Patch (v2)
Comment 4 Brent Fulgham 2016-03-04 14:44:10 PST 
Comment on attachment 273046 [details]
Patch (v2)

Revised to expect settings flag to be on the WebsiteDataStore, not the WKContext.
Comment 5 Andy Estes 2016-03-04 14:51:39 PST 
Comment on attachment 273046 [details]
Patch (v2)

This looks right to me. If you did the APIWebsiteDataStore part in https://bugs.webkit.org/show_bug.cgi?id=154278 and landed that patch, then you could make this be more than a stub. WKWebsiteDataStoreRef would just need to call into APIWebsiteDataStore, which would already be wired up properly.
Comment 6 Brent Fulgham 2016-03-04 16:40:03 PST 
Committed r197598: <http://trac.webkit.org/changeset/197598>