Bug 154988 - [ES6] Make Unicode RegExp pattern parsing conform to the spec
Summary: [ES6] Make Unicode RegExp pattern parsing conform to the spec
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-03 16:18 PST by Michael Saboff
Modified: 2016-03-03 17:24 PST (History)
5 users (show)

See Also:

Attachments
Patch (28.09 KB, patch)
2016-03-03 16:57 PST, Michael Saboff 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2016-03-03 16:18:52 PST 
The parsing of a RegExp pattern with the unicode flag is more restrictive than without.  This is a follow up to change set r197426 to add those restrictions and corresponding tests.
Comment 1 Michael Saboff 2016-03-03 16:57:30 PST 
Created attachment 272800 [details]
Patch
Comment 2 Benjamin Poulain 2016-03-03 17:04:03 PST 
Comment on attachment 272800 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272800&action=review

> Source/JavaScriptCore/yarr/YarrSyntaxChecker.cpp:56
> +    return parse(syntaxChecker, pattern, flags.find('u') != notFound);

flags.contains('u')
Comment 3 Geoffrey Garen 2016-03-03 17:04:34 PST 
r=me
Comment 4 Michael Saboff 2016-03-03 17:24:18 PST 
Committed r197534: <http://trac.webkit.org/changeset/197534>