Bug 154983 - ComposedTreeIterator may traverse slotted nodes multiple times
Summary: ComposedTreeIterator may traverse slotted nodes multiple times
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-03 14:59 PST by Antti Koivisto
Modified: 2016-03-30 00:07 PDT (History)
5 users (show)

See Also:

Attachments
patch (9.99 KB, patch)
2016-03-03 15:34 PST, Antti Koivisto 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2016-03-03 14:59:22 PST 
Traversal of slotted nodes can escape to real siblings. Those siblings are then traversed again as slotted nodes.
Comment 1 Antti Koivisto 2016-03-03 15:34:57 PST 
Created attachment 272781 [details]
patch
Comment 2 Ryosuke Niwa 2016-03-03 15:54:28 PST 
Comment on attachment 272781 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272781&action=review

> LayoutTests/fast/shadow-dom/composed-tree-slots.html:1
> +<script>

Missing DOCTYPE.

> LayoutTests/fast/shadow-dom/composed-tree-slots.html:49
> +var console = document.querySelector("#console");

Can we use some other variable name to avoid shadowing window.console?
Comment 3 Antti Koivisto 2016-03-30 00:07:00 PDT 
http://trac.webkit.org/changeset/197553