WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
154978
Update style guide to reflect our style of only using "override" or "final" when overriding virtual methods
https://bugs.webkit.org/show_bug.cgi?id=154978
Summary
Update style guide to reflect our style of only using "override" or "final" w...
Saam Barati
Reported
2016-03-03 11:42:50 PST
Opposed to only using "virtual" or both "virtual" and "override"
Attachments
patch
(2.14 KB, patch)
2016-03-03 23:48 PST
,
Saam Barati
darin
: review+
Details
Formatted Diff
Diff
patch for landing
(3.10 KB, patch)
2016-03-06 14:28 PST
,
Saam Barati
no flags
Details
Formatted Diff
Diff
patch for landing v2
(3.11 KB, patch)
2016-03-06 14:29 PST
,
Saam Barati
no flags
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Saam Barati
Comment 1
2016-03-03 23:48:06 PST
Created
attachment 272837
[details]
patch
Darin Adler
Comment 2
2016-03-04 14:06:05 PST
Comment on
attachment 272837
[details]
patch This is good, but you should probably revise to include the rule about final. We want to use exactly one of final, override, and virtual.
Saam Barati
Comment 3
2016-03-06 14:28:15 PST
Created
attachment 273144
[details]
patch for landing
Saam Barati
Comment 4
2016-03-06 14:29:24 PST
Created
attachment 273145
[details]
patch for landing v2 changed bug title to reflect "final" keyword
Saam Barati
Comment 5
2016-03-06 14:30:29 PST
landed in:
http://trac.webkit.org/changeset/197643
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug