Bug 154978 - Update style guide to reflect our style of only using "override" or "final" when overriding virtual methods
Summary: Update style guide to reflect our style of only using "override" or "final" w...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Website (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Saam Barati
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-03 11:42 PST by Saam Barati
Modified: 2016-03-06 14:30 PST (History)
5 users (show)

See Also:

Attachments
patch (2.14 KB, patch)
2016-03-03 23:48 PST, Saam Barati 		darin: review+
Details | Formatted Diff | Diff
patch for landing (3.10 KB, patch)
2016-03-06 14:28 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
patch for landing v2 (3.11 KB, patch)
2016-03-06 14:29 PST, Saam Barati 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Saam Barati 2016-03-03 11:42:50 PST 
Opposed to only using "virtual" or both "virtual" and "override"
Comment 1 Saam Barati 2016-03-03 23:48:06 PST 
Created attachment 272837 [details]
patch
Comment 2 Darin Adler 2016-03-04 14:06:05 PST 
Comment on attachment 272837 [details]
patch

This is good, but you should probably revise to include the rule about final. We want to use exactly one of final, override, and virtual.
Comment 3 Saam Barati 2016-03-06 14:28:15 PST 
Created attachment 273144 [details]
patch for landing
Comment 4 Saam Barati 2016-03-06 14:29:24 PST 
Created attachment 273145 [details]
patch for landing v2

changed bug title to reflect "final" keyword
Comment 5 Saam Barati 2016-03-06 14:30:29 PST 
landed in:
http://trac.webkit.org/changeset/197643