Bug 154952 - Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href
Summary: Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://html.spec.whatwg.org/multipag...
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-03-02 20:42 PST by Chris Dumez
Modified: 2022-02-27 23:20 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.58 KB, patch)
2016-03-02 21:07 PST, Chris Dumez 		rniwa: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-03-02 20:42:15 PST 
Drop [TreatNullAs=LegacyNullString] from HTMLBaseElement.href as this does not match the specification:
https://html.spec.whatwg.org/multipage/semantics.html#the-base-element

Firefox and Chrome both convert null to the string "null".
Comment 1 Chris Dumez 2016-03-02 21:07:46 PST 
Created attachment 272726 [details]
Patch
Comment 2 Ryosuke Niwa 2016-03-02 22:09:43 PST 
Comment on attachment 272726 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272726&action=review

> Source/WebCore/ChangeLog:14
> +        No new tests, already covered by existing test.

You're adding a test case to fast/dom/HTMLBaseElement/href-attribute-resolves-with-respect-to-document.html
so you should list that instead of saying there's an existing coverage.
Comment 3 Chris Dumez 2016-03-02 22:31:29 PST 
Committed r197494: <http://trac.webkit.org/changeset/197494>