Bug 154951 - Drop [TreatNullAs=EmptyString] from URL interface attributes
Summary: Drop [TreatNullAs=EmptyString] from URL interface attributes
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL: https://url.spec.whatwg.org/#api
Keywords: WebExposed
Depends on:
Blocks:
 
Reported: 2016-03-02 20:22 PST by Chris Dumez
Modified: 2016-03-03 09:25 PST (History)
7 users (show)

See Also:

Attachments
Patch (14.49 KB, patch)
2016-03-02 20:24 PST, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2016-03-02 20:22:14 PST 
Drop [TreatNullAs=EmptyString] from URL interface attributes to match the specification:
https://url.spec.whatwg.org/#api

Firefox and Chrome both already follow the specification and convert null to the "null" string.
Comment 1 Chris Dumez 2016-03-02 20:24:32 PST 
Created attachment 272724 [details]
Patch
Comment 2 Darin Adler 2016-03-03 08:34:35 PST 
Comment on attachment 272724 [details]
Patch

This seems like the kind of behavior that WebKit-specific content that has never been used with another web engine might rely on. Eventually it will become too risky to make this kind of change unless we have a lot of time to test things like iOS apps before Apple puts out a release with the change in it.
Comment 3 WebKit Commit Bot 2016-03-03 09:25:18 PST 
Comment on attachment 272724 [details]
Patch

Clearing flags on attachment: 272724

Committed r197507: <http://trac.webkit.org/changeset/197507>
Comment 4 WebKit Commit Bot 2016-03-03 09:25:22 PST 
All reviewed patches have been landed.  Closing bug.