Bug 154946 – Add URL::highLevelDomain() function

• Status: NEW
• Component: WebCore Misc.

[John Wilander]

Add a highLevelDomain() function to the URL class.

[John Wilander]

rdar://problem/24701008

[John Wilander]

Created attachment 272718 [details]
Patch

[Alexey Proskuryakov]

Comment on attachment 272718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272718&action=review

> Source/WebCore/platform/URL.cpp:695
> +String URL::highLevelDomain() const
> +{
> +    return topPrivatelyControlledDomain(host());

Do we need two different names for this?

Searching the internet, I see "hight level domain" being mostly used as a synonym to "top level domain", if used at all.

[Darin Adler]

Comment on attachment 272718 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272718&action=review

>> Source/WebCore/platform/URL.cpp:695
>> +    return topPrivatelyControlledDomain(host());
> 
> Do we need two different names for this?
> 
> Searching the internet, I see "hight level domain" being mostly used as a synonym to "top level domain", if used at all.

Terminology is important, I agree. I am concerned about calling these both hosts and domains, and also calling them both top level domains and high level domains.

I don’t think this convenience function improves things much. If we only have a few call sites, then I think topPrivatelyControlledDomain(location.host()) would be fine at the call sites.

> Source/WebCore/platform/URL.h:108
>      WEBCORE_EXPORT String host() const;
> +    WEBCORE_EXPORT String highLevelDomain() const;
>      WEBCORE_EXPORT unsigned short port() const;

Please don’t mix this in with functions that just return pieces of the URL. This is a higher level operation and should be in its own paragraph below or with other similarly high level functions.

[Alexey Proskuryakov]

Comment on attachment 272718 [details]
Patch

Marking r- based on feedback.

[Brent Fulgham]

*** Bug 154341 has been marked as a duplicate of this bug. ***