Bug 154919 – Add support for the "first" value of the hanging-punctuation property

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Dave Hyatt]

Add support for the "first" value of the hanging-punctuation property.

[Dave Hyatt]

Created attachment 272660 [details]
Patch

[WebKit Commit Bot]

Attachment 272660 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/line/BreakingContext.h:791:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/rendering/RenderBlockLineLayout.cpp:813:  Boolean expressions that span multiple lines should have their operators on the left side of the line instead of the right side.  [whitespace/operators] [4]
ERROR: Source/WebCore/rendering/RenderBlockLineLayout.cpp:813:  Multi line control clauses should use braces.  [whitespace/braces] [4]
ERROR: Source/WebCore/rendering/RenderBlockFlow.cpp:4186:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 4 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 272661 [details]
Patch

[WebKit Commit Bot]

Attachment 272661 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/line/BreakingContext.h:791:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Dave Hyatt]

Created attachment 272663 [details]
Patch

[WebKit Commit Bot]

Attachment 272663 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/line/BreakingContext.h:791:  Multi line control clauses should use braces.  [whitespace/braces] [4]
Total errors found: 1 in 13 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Simon Fraser (smfr)]

Comment on attachment 272663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272663&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        New tests added in fast/text.

Can you reference the spec here please.

> Source/WebCore/rendering/RenderBlockFlow.cpp:4067
> +    bool canHangPunctuationAtStart = styleToUse.hangingPunctuation() & FirstHangingPunctuation;

Maybe add helpers like RenderStyle::hasFirstHangingPunctuation()

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:809
> +static bool inlineAncestorHasStartBorderPaddingOrMargin(const RenderBlockFlow& block, InlineBox* box)

const InlineBox&

> Source/WebCore/rendering/RenderBlockLineLayout.cpp:820
> +static bool isLastInFlowRun(BidiRun* run)

const BidiRun&

[Dave Hyatt]

Landed in r197464.