Bug 154918 - REGRESSION(r197409): [GTK] Web process always crashes on WebPage construction after r197409
Summary: REGRESSION(r197409): [GTK] Web process always crashes on WebPage construction...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk, Regression
Depends on:
Blocks:
 
Reported: 2016-03-02 09:15 PST by Carlos Garcia Campos
Modified: 2016-03-02 09:59 PST (History)
4 users (show)

See Also:

Attachments
Patch (3.68 KB, patch)
2016-03-02 09:21 PST, Carlos Garcia Campos 		no flags Details | Formatted Diff | Diff
Patch (3.79 KB, patch)
2016-03-02 09:24 PST, Carlos Garcia Campos 		zan: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2016-03-02 09:15:36 PST 
We have an incorrect check in DrawingAreaImpl constructor that has never actually worked because it uses the page settings before they were initialized. But that has been fixed in r197409 and now we are always forcing accelerated compositing mode incorrectly, because m_alwaysUseCompositing is set in the constructor and never changed again.
Comment 1 Carlos Garcia Campos 2016-03-02 09:21:31 PST 
Created attachment 272658 [details]
Patch

Please, review this, *all* the tests in our bots are currently broken
Comment 2 Carlos Garcia Campos 2016-03-02 09:24:42 PST 
Created attachment 272659 [details]
Patch

Sorry, I submitted the wrong patch by mistake.
Comment 3 Carlos Garcia Campos 2016-03-02 09:59:32 PST 
Committed r197452: <http://trac.webkit.org/changeset/197452>