RESOLVED FIXED 154904
[JSC] Simplify ArithMod(ArithMod(x, const1), const2) if const2 >= const1 
https://bugs.webkit.org/show_bug.cgi?id=154904
Summary [JSC] Simplify ArithMod(ArithMod(x, const1), const2) if const2 >= const1
Benjamin Poulain
Reported 2016-03-01 21:07:14 PST
[JSC] Simplify ArithMod(ArithMod(x, const1), const2) if const2 >= const1
Attachments
Patch (4.49 KB, patch)
2016-03-01 21:09 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Patch for landing (4.47 KB, patch)
2016-03-01 22:57 PST, Benjamin Poulain 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Benjamin Poulain
Comment 1 2016-03-01 21:09:27 PST
Created attachment 272630 [details] Patch
Saam Barati
Comment 2 2016-03-01 22:15:08 PST
Comment on attachment 272630 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=272630&action=review LGTM > Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:179 > + // Out: Identity(ArithMod(x, const1) Style nit: parens aren't balanced > Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:184 > + && m_node->child1()->binaryUseKind() Should this also be == Int32Use?
Benjamin Poulain
Comment 3 2016-03-01 22:16:15 PST
(In reply to comment #2) > Comment on attachment 272630 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=272630&action=review > > LGTM > > > Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:179 > > + // Out: Identity(ArithMod(x, const1) > > Style nit: parens aren't balanced > > > Source/JavaScriptCore/dfg/DFGStrengthReductionPhase.cpp:184 > > + && m_node->child1()->binaryUseKind() > > Should this also be == Int32Use? Yep, indeed!
Benjamin Poulain
Comment 4 2016-03-01 22:57:18 PST
Created attachment 272637 [details] Patch for landing
WebKit Commit Bot
Comment 5 2016-03-01 23:53:12 PST
Comment on attachment 272637 [details] Patch for landing Clearing flags on attachment: 272637 Committed r197445: <http://trac.webkit.org/changeset/197445>
WebKit Commit Bot
Comment 6 2016-03-01 23:53:16 PST
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.