Bug 154900 - The most aggressive form of RegExpTest/RegExpExec should speculate more aggressively than just cell
Summary: The most aggressive form of RegExpTest/RegExpExec should speculate more aggre...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Filip Pizlo
URL:
Keywords:
Depends on:
Blocks: 155070
  Show dependency treegraph
 
Reported: 2016-03-01 19:35 PST by Filip Pizlo
Modified: 2016-03-05 16:48 PST (History)
5 users (show)

See Also:


Attachments
work in progress (12.47 KB, patch)
2016-03-05 14:23 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff
the patch (25.95 KB, patch)
2016-03-05 15:12 PST, Filip Pizlo
sbarati: review+
Details | Formatted Diff | Diff
patch for landing (25.89 KB, patch)
2016-03-05 16:16 PST, Filip Pizlo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Filip Pizlo 2016-03-01 19:35:54 PST
Things.
Comment 1 Filip Pizlo 2016-03-05 14:23:54 PST
Created attachment 273098 [details]
work in progress
Comment 2 Filip Pizlo 2016-03-05 15:12:07 PST
Created attachment 273100 [details]
the patch
Comment 3 WebKit Commit Bot 2016-03-05 15:13:52 PST
Attachment 273100 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGOperations.cpp:629:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Saam Barati 2016-03-05 15:28:18 PST
Comment on attachment 273100 [details]
the patch

LGTM
Comment 5 Filip Pizlo 2016-03-05 16:16:36 PST
Created attachment 273107 [details]
patch for landing
Comment 6 WebKit Commit Bot 2016-03-05 16:19:17 PST
Attachment 273107 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/dfg/DFGOperations.cpp:629:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 11 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 Filip Pizlo 2016-03-05 16:48:32 PST
Landed in http://trac.webkit.org/changeset/197622