Bug 154899 - Subpixel layout: Enable vertical/horizontal subpixel spacing for tables.
Summary: Subpixel layout: Enable vertical/horizontal subpixel spacing for tables.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2016-03-01 19:19 PST by zalan
Modified: 2016-03-02 09:15 PST (History)
2 users (show)

See Also:


Attachments
Patch (44.97 KB, patch)
2016-03-01 21:14 PST, zalan
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2016-03-01 19:19:25 PST
SSIA.
Comment 1 zalan 2016-03-01 21:14:55 PST
Created attachment 272631 [details]
Patch
Comment 2 WebKit Commit Bot 2016-03-01 21:15:50 PST
Attachment 272631 [details] did not pass style-queue:


ERROR: Source/WebCore/rendering/style/StyleInheritedData.h:49:  horizontal_border_spacing is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
ERROR: Source/WebCore/rendering/style/StyleInheritedData.h:50:  vertical_border_spacing is incorrectly named. Don't use underscores in your identifier names.  [readability/naming/underscores] [4]
Total errors found: 2 in 16 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2016-03-01 21:30:57 PST
Comment on attachment 272631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=272631&action=review

> Source/WebCore/ChangeLog:8
> +        Reviewed by NOBODY (OOPS!).
> +
> +        Test: fast/table/hidpi-vertical-and-horizontal-spacing.html

Some words here please.
Comment 4 zalan 2016-03-02 09:15:58 PST
Committed r197450: <http://trac.webkit.org/changeset/197450>